-
Notifications
You must be signed in to change notification settings - Fork 218
Conversation
Awesome |
The https://github.com/kubernetes/features/blob/master/release-1.8/release_notes_draft.md#major-themes |
@@ -19,7 +19,7 @@ contexts: | |||
user: kubelet | |||
`) | |||
|
|||
var KubeSystemSARoleBindingTemplate = []byte(`apiVersion: rbac.authorization.k8s.io/v1alpha1 | |||
var KubeSystemSARoleBindingTemplate = []byte(`apiVersion: rbac.authorization.k8s.io/v1beta1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be v1
per the release notes draft: https://github.com/kubernetes/features/blob/master/release-1.8/release_notes_draft.md#auth-1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either works. v1alpha1 doesn't anymore due to kubernetes/kubernetes#51839
Seeing this error when trying to use this PR
edit: removing the daemonsets commits fixed this. |
Reproduced... It has something to do with defaulting labels now. Looking into it. |
@ericchiang fixed... updated the selectors on the daemonsets. |
pkg/asset/internal/templates.go
Outdated
@@ -1193,7 +1205,7 @@ data: | |||
} | |||
`) | |||
|
|||
var KubeCalicoTemplate = []byte(`apiVersion: extensions/v1beta1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look for CalicoNodeTemplate when you rebase, this was renamed on master
Can one of the admins verify this patch? |
@rphillips can we update this PR now that 1.8 is out? (cc @squat) |
1.8.0 hyperkube is about to get cut. Waiting for the necessary LGTM and it will be available. xref coreos/kubernetes#167 |
yep.. then I'll tweak this PR to remove the API bumps, and do a migration of the APIs in a separate PR |
eb71219
to
7f313ca
Compare
closing in favor of #729 |
Issues:
rbac.authorization.k8s.io/v1beta1
instead of v1alpha1