Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update containerd socket in windows #914

Merged
merged 1 commit into from
May 2, 2022
+2 −3
Merged

update containerd socket in windows #914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/crictl/main_windows.go
View file
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@ import (
"path/filepath"
)

var defaultRuntimeEndpoints = []string{"npipe:////./pipe/dockershim", "npipe:////./pipe/containerd", "npipe:////./pipe/crio", "npipe:////./pipe/cri-dockerd"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does crio support windows at all? Perhaps it can be removed.

var defaultRuntimeEndpoints = []string{"npipe:////./pipe/dockershim", "npipe:////./pipe/containerd-containerd", "npipe:////./pipe/cri-dockerd"}
var defaultConfigPath string

var shutdownSignals = []os.Signal{os.Interrupt}
3 changes: 1 addition & 2 deletions docs/crictl.md
View file
Original file line number Diff line number Diff line change
@@ -73,8 +73,7 @@ crictl by default connects on Unix to:
or on Windows to:

- `npipe:////./pipe/dockershim` or
- `npipe:////./pipe/containerd` or
- `npipe:////./pipe/crio` or
- `npipe:////./pipe/containerd-containerd` or
- `npipe:////./pipe/cri-dockerd`

For other runtimes, use: