-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PersistentVolumeClaimPolicy to approved api #2652
Conversation
1afd3a1
to
96d095d
Compare
LGTM |
I think it needs the lgtm to be /lgtm? :-)
…On Tue, Apr 27, 2021 at 11:09 PM Wojciech Tyczynski < ***@***.***> wrote:
LGTM
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2652 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIJCBAFIGQEUYH5RP2K6Q6DTK6RAPANCNFSM43WKCPRA>
.
|
/lgtm |
I know, but I don't have permission to approve anyway, so SIG storage leads need to approve anyway... @msau42 - in enhancements repo, explicit /approve is required... |
Ah! Thanks for clarifying Wojciech. |
/assign @janetkuo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattcary, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mattcary the verify failure is real, please fix and ping me to get this re-tagged. |
My apologies. Verify is fixed. Sorry for the churn. |
/lgtm |
Here are changes to the StatefulSet autodelete KEP after going through the api review (k/k PR kubernetes/kubernetes#99378).
/assign @msau42
/assign @wojtek-t