Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PersistentVolumeClaimPolicy to approved api #2652

Merged
merged 1 commit into from
May 10, 2021

Conversation

mattcary
Copy link
Contributor

Here are changes to the StatefulSet autodelete KEP after going through the api review (k/k PR kubernetes/kubernetes#99378).

/assign @msau42
/assign @wojtek-t

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Apr 28, 2021
@k8s-ci-robot k8s-ci-robot requested review from kow3ns and soltysh April 28, 2021 05:17
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 28, 2021
@mattcary mattcary force-pushed the api branch 2 times, most recently from 1afd3a1 to 96d095d Compare April 28, 2021 06:08
@wojtek-t
Copy link
Member

LGTM

@mattcary
Copy link
Contributor Author

mattcary commented Apr 28, 2021 via email

@msau42
Copy link
Member

msau42 commented Apr 28, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2021
@wojtek-t
Copy link
Member

I think it needs the lgtm to be /lgtm? :-)

I know, but I don't have permission to approve anyway, so SIG storage leads need to approve anyway...

@msau42 - in enhancements repo, explicit /approve is required...

@mattcary
Copy link
Contributor Author

Ah! Thanks for clarifying Wojciech.
/assign @janetkuo for sig-apps approval

@mattcary
Copy link
Contributor Author

/assign @janetkuo

@wojtek-t
Copy link
Member

wojtek-t commented May 5, 2021

/assign @soltysh

@soltysh @janetkuo - can you please approve from the SIG perspective?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2021
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2021
@soltysh
Copy link
Contributor

soltysh commented May 10, 2021

@mattcary the verify failure is real, please fix and ping me to get this re-tagged.

@mattcary
Copy link
Contributor Author

My apologies. Verify is fixed. Sorry for the churn.

@janetkuo
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2516bd3 into kubernetes:master May 10, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants