-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alphabetize languages, change weights accordingly #10503
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 3a452d4 https://deploy-preview-10503--kubernetes-io-master-staging.netlify.com |
config.toml
Outdated
[languages.ko] | ||
title = "Kubernetes" | ||
description = "Production-Grade Container Orchestration" | ||
languageName = "한국인 Korean" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gochist @claudiajkang I used Google here, please correct this if it's wrong or if there's a better idiom!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use 한국어. 한국인 means Korean people.
Deploy preview for kubernetes-io-master-staging ready! Built with commit ee0d17d https://deploy-preview-10503--kubernetes-io-master-staging.netlify.com |
Deploy preview for kubernetes-io-master-staging ready! Built with commit c6cdfb2 https://deploy-preview-10503--kubernetes-io-master-staging.netlify.com |
More updates Add Korean in Korean Add English to languageName Feedback from gochist
I'm closing this PR to consolidate localization work in #10485, which now includes this PR's commit as a |
This PR:
config.toml
/assign @gochist @claudiajkang