Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alphabetize languages, change weights accordingly #10503

Closed
wants to merge 1 commit into from
Closed

Alphabetize languages, change weights accordingly #10503

wants to merge 1 commit into from

Conversation

zacharysarah
Copy link
Contributor

This PR:

  • Alphabetizes language weighting in config.toml
  • Adds Korean characters to the Korean language selection

/assign @gochist @claudiajkang

@kubernetes-docs-i18n-bot kubernetes-docs-i18n-bot added the language/en Issues or PRs related to English language label Oct 4, 2018
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zacharysarah

If they are not already assigned, you can assign the PR to them by writing /assign @zacharysarah in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 4, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 3a452d4

https://deploy-preview-10503--kubernetes-io-master-staging.netlify.com

config.toml Outdated
[languages.ko]
title = "Kubernetes"
description = "Production-Grade Container Orchestration"
languageName = "한국인 Korean"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gochist @claudiajkang I used Google here, please correct this if it's wrong or if there's a better idiom!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use 한국어. 한국인 means Korean people.

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit ee0d17d

https://deploy-preview-10503--kubernetes-io-master-staging.netlify.com

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Oct 4, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit c6cdfb2

https://deploy-preview-10503--kubernetes-io-master-staging.netlify.com

More updates

Add Korean in Korean

Add English to languageName

Feedback from gochist
@zacharysarah
Copy link
Contributor Author

I'm closing this PR to consolidate localization work in #10485, which now includes this PR's commit as a cherry-pick. 🍒

/cc @gochist @claudiajkang

@zacharysarah zacharysarah deleted the update-ko-weight branch October 6, 2018 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants