Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/user-guide/pod-security-policy: list all available PSP fields #3012

Merged
merged 1 commit into from
Apr 5, 2017

Conversation

php-coder
Copy link
Contributor

@php-coder php-coder commented Mar 27, 2017

Fixes #2116


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 27, 2017
@php-coder
Copy link
Contributor Author

@pweil- Is there a way to preview this changes? Maybe generate the docs locally (I didn't search yet.)

@pweil-
Copy link

pweil- commented Mar 27, 2017

@pweil- Is there a way to preview this changes? Maybe generate the docs locally (I didn't search yet.)

you can stage locally with docker: https://kubernetes.io/docs/contribute/stage-documentation-changes/

| The user ID | `runAsUser` |
| Configuring allowable supplemental groups | `supplementalGroups` |
| Allocating an FSGroup that owns the pod's volumes | `fSGroup` |
| Requiring the use of a read only root file system | `readOnlyRootFilesystem` |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also include info about allowed annotations for alpha features:

// The annotation key specifying the default seccomp profile.
	DefaultProfileAnnotationKey = "seccomp.security.alpha.kubernetes.io/defaultProfileName"
	// The annotation key specifying the allowed seccomp profiles.
	AllowedProfilesAnnotationKey = "seccomp.security.alpha.kubernetes.io/allowedProfileNames"
// SysctlsPodSecurityPolicyAnnotationKey represents the key of a whitelist of
	// allowed safe and unsafe sysctls in a pod spec. It's a comma-separated list of plain sysctl
	// names or sysctl patterns (which end in *). The string "*" matches all sysctls.
	SysctlsPodSecurityPolicyAnnotationKey string = "security.alpha.kubernetes.io/sysctls"
// The annotation key specifying the default AppArmor profile.
	DefaultProfileAnnotationKey = "apparmor.security.beta.kubernetes.io/defaultProfileName"
	// The annotation key specifying the allowed AppArmor profiles.
	AllowedProfilesAnnotationKey = "apparmor.security.beta.kubernetes.io/allowedProfileNames"

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(search annotation in the security/podsecuritypolicy directory to find which ones are used in strategies or providers)

@php-coder php-coder force-pushed the gh2116_list_psp_fields branch 2 times, most recently from 1c71b4b to ea9efaa Compare March 31, 2017 14:53
@php-coder
Copy link
Contributor Author

PTAL @pweil-

@chenopis
Copy link
Contributor

chenopis commented Apr 4, 2017

@pweil- Ping.

@pweil-
Copy link

pweil- commented Apr 4, 2017

This is waiting on update with reference to the comment on #3174 unless someone disagrees or if we have an official policy wrt the statement about annotations (which overrides my previous request for change) 😄

@php-coder
Copy link
Contributor Author

The code is here so I don't understand why we're not documenting it. How user will know about possible features then?

@pweil-
Copy link

pweil- commented Apr 4, 2017

The code is here so I don't understand why we're not documenting it. How user will know about possible features then?

I'm not disagreeing. Best thing to do is take the conversation to the other issue and work out the reasoning there. Leave this as-is until then.

@php-coder
Copy link
Contributor Author

php-coder commented Apr 5, 2017

@pweil- Would you approve this PR if I remove mentions about annotations? Documentation is updating very frequently I don't want to keep this PR open for a long time.

@pweil-
Copy link

pweil- commented Apr 5, 2017

If you'd like to leave it out for now while the discussion is ongoing then this is LGTM

This also adds a couple of improvements:
- rename SELinuxContext to SELinux
- improve options displaying
@php-coder php-coder force-pushed the gh2116_list_psp_fields branch from 998b869 to 002194f Compare April 5, 2017 13:27
@php-coder
Copy link
Contributor Author

I've adapted my changes to the latest master (where this file were moved to other place).

@pweil- PTAL.

@php-coder
Copy link
Contributor Author

@chenopis It's ready to merge.

@chenopis chenopis merged commit 8d8409b into kubernetes:master Apr 5, 2017
@php-coder php-coder deleted the gh2116_list_psp_fields branch April 6, 2017 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants