Merge branch 'master' into Improve-sidenav-story

packages/smarthr-ui/src/components/AppHeader/components/mobile/TenantSelector.tsx

@@ -38,7 +38,7 @@ export const TenantSelector: FC<Props> = ({ tenants, currentTenantId, onTenantSe
 
   return (
     <Dropdown>
-      {/* eslint-disable-next-line smarthr/a11y-trigger-has-button */}
+      {}
       <DropdownTrigger>
         <button type="button" className={tenantDropdownTriggerButton()}>
           {tenantName}

packages/smarthr-ui/src/components/ComboBox/MultiComboBox/stories/MultiComboBox.stories.tsx

@@ -7,7 +7,6 @@ import { Stack } from '../../../Layout'
 import { Text } from '../../../Text'
 import { MultiComboBox } from '../MultiComboBox'
 
-// eslint-disable-next-line storybook/prefer-pascal-case
 export const defaultItems = {
   'option 1': {
     label: 'option 1',

packages/smarthr-ui/src/components/Dialog/FormDialog/FormDialogContentInner.tsx

@@ -87,7 +87,7 @@ export const FormDialogContentInner: FC<FormDialogContentInnerProps> = ({
   const { form, wrapper, actionArea, buttonArea, message } = formDialogContentInner()
 
   return (
-    // eslint-disable-next-line smarthr/best-practice-for-layouts, smarthr/a11y-heading-in-sectioning-content
+    // eslint-disable-next-line smarthr/best-practice-for-layouts
     <Stack gap={0} as={Section} className={wrapper()}>
       <DialogHeader title={title} subtitle={subtitle} titleTag={titleTag} titleId={titleId} />
       <form onSubmit={handleSubmitAction} className={form()}>

packages/smarthr-ui/src/components/SideNav/SideNavItemButton.tsx

@@ -59,14 +59,18 @@ export const SideNavItemButton: FC<Props & ElementProps> = ({
   id,
   title,
   prefix,
-  isSelected = false,
-  size = 'default',
+  isSelected,
+  size,
   onClick,
   children,
 }) => {
-  const handleClick = onClick
-    ? (e: React.MouseEvent<HTMLButtonElement, MouseEvent>) => onClick(e, id)
-    : undefined
+  const handleClick = useMemo(
+    () =>
+      onClick
+        ? (e: React.MouseEvent<HTMLButtonElement, MouseEvent>) => onClick(e, e.currentTarget.value)
+        : undefined,
+    [onClick],
+  )
 
   const { wrapperStyle, buttonStyle, buttonInnerStyle } = useMemo(() => {
     const { wrapper, button, buttonInner } = sideNavItem()

packages/smarthr-ui/src/components/WarekiPicker/stories/VRTWarekiPicker.stories.tsx

@@ -1,6 +1,3 @@
-/* eslint-disable smarthr/a11y-input-has-name-attribute */
-/* eslint-disable smarthr/a11y-prohibit-input-placeholder */
-/* eslint-disable smarthr/a11y-input-in-form-control */
 import { userEvent, within } from '@storybook/test'
 import dayjs from 'dayjs'
 import React from 'react'

packages/smarthr-ui/src/components/WarekiPicker/stories/WarekiPicker.stories.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable smarthr/a11y-input-in-form-control */
 import { userEvent, within } from '@storybook/test'
 import dayjs from 'dayjs'
 import React from 'react'