fix!: ModelessDialogの見出し部分がHeadingかつ、自動レベル計算されるように修正する SHRUI-961 #5459
+50
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
yagimushi
force-pushed
the
fix-modeless-dialog
branch
from
1ee1ba9 to
1471819
Compare
yagimushi
force-pushed
the
fix-modeless-dialog
branch
from
ffe235b to
d5919ed
Compare
AtsushiM
requested review from
misako0927 and
Qs-F
and removed request for
a team
AtsushiM
commented
Mar 17, 2025
| @@ -55,7 +56,7 @@ export const DialogOverlap: FC<Props> = ({ isOpen, className, children }) => { | |||
| unmountOnExit | |||
| nodeRef={nodeRef} | |||
| > | |||
| <Center verticalCentering ref={nodeRef} className={styles}> | |||
| <Center verticalCentering ref={nodeRef} className={styles} as={as}> | |||
There was a problem hiding this comment.
styleの関係でDialog全体をSectionでラップする形に変更します。
asはoptionなのでModelssDialog以外には影響ありません
AtsushiM
commented
Mar 17, 2025
| } = useMemo(() => { | ||
| const { overlap, wrapper, headerEl, title, dialogHandler, closeButtonLayout, footerEl } = | ||
| modelessDialog() | ||
| const classNames = useMemo(() => { |
There was a problem hiding this comment.
styleのフォーマットを他と合わせてclassNamesにまとめ直しています。
AtsushiM
commented
Mar 17, 2025
AtsushiM
commented
Mar 17, 2025
| overlap: overlap({ className }), | ||
| wrapper: wrapper({ resizable }), | ||
| header: headerEl(), | ||
| title: titleEl(), |
There was a problem hiding this comment.
コンポーネントのheader属性をtitle属性に変更した関係で、内部変数が同じ名称になってしまったため、内部変数の名称を変えています
AtsushiM
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
SHRUI-961
概要
変更内容
確認方法