Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remaining Eth JSON-RPC methods #5

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

loredanacirstea
Copy link
Contributor

Now, all methods are listed, in accordance with https://github.com/ethereum/wiki/wiki/JSON-RPC.

@loredanacirstea
Copy link
Contributor Author

Next week, I hope to start writing some tests for them.

@zot
Copy link
Member

zot commented May 16, 2020

Wow, looks great! The changes appear to be correct, just from looking at them, but tests are indeed better than just eyeballing them.

It appears that the Web 3 Foundation is unfortunately abandoning Whisper:

Unfortunately, the evolution and adoption of Whisper has been stunted, which is despite the rapid advancement of applications. The lack of development means that Whisper is not able to provide the scaling that we need, nor is it feasible for projects to create their own bespoke messaging protocol. What we really need is a new protocol to handle transient messaging at scale. We believe this is a necessary cornerstone for enabling the mainstream adoption of DApps.

I used Whisper in a 2-player Ethereum-based and I do like the idea of Whisper so it's a shame to see it go. Any p2p messaging would have worked for the purposes of the game, though, so libp2p will be sufficient for that, if the JSON API exposes enough functionality.

@loredanacirstea
Copy link
Contributor Author

@zot , True. I thought it best to follow the current standards from https://github.com/ethereum/wiki/wiki/JSON-RPC, without making value judgments, also considering that:

But you can make value judgments, so if there are other methods aside from shh* that you don't want to be included, let me know.

@zot
Copy link
Member

zot commented May 17, 2020

I'm happy to include them, I wanted to make sure you and your org knew about shh though, in case you are planning to depend on them

@zot
Copy link
Member

zot commented Jul 24, 2020

Sheesh, I thought I merged this already...

@zot zot merged commit 2ccbf68 into lambda-mechanics:master Jul 24, 2020
@zot
Copy link
Member

zot commented Jul 24, 2020

Sorry about that -- merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants