Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Renovate with reusable workflows #128

Closed
wants to merge 6 commits into from
Closed

Prepare for Renovate with reusable workflows #128

wants to merge 6 commits into from

Conversation

ghostwriter
Copy link
Contributor

Q A
QA yes

Description

Adding Renovate to Laminas, Mezzio repositories. https://gist.github.com/weierophinney/49ca8ae2b916d898dd3d4162b26ff41b

  • Configure minimum supported PHP version
  • Update composer dependencies
  • Update to reusable Continuous Integration workflow
  • Update to reusable Automatic Releases workflow

Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires rolling back to a much smaller composer.lock change (just hash change)

@Ocramius Ocramius added this to the 4.6.0 milestone Feb 21, 2022
@Ocramius Ocramius self-assigned this Feb 22, 2022
@Ocramius
Copy link
Member

Hmm, the psalm issues seem to be unrelated: I think the reason for the failures is that vimeo/psalm started used config.platform.php to determine which version it is running on.

We need to add phpVersion="" to psalm.xml here, I think.

psalm.xml Outdated
@@ -1,6 +1,7 @@
<?xml version="1.0"?>
<psalm
errorLevel="1"
phpVersion="7.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, wasn't clear - the PHP version should probably be 8.1, which is where psalm is run :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understood that part but got confused because we are still running ci check on the minimum supported PHP version,PHP 7.4.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm generally confused by the CI output anyway 🤷

Probably need to get back to this at a later point in time, checking it out locally, because those CI failures should really not be there, unless the PHP version changed some details internally too 🤔

@Ocramius Ocramius removed their assignment Feb 22, 2022
@Ocramius Ocramius self-requested a review February 22, 2022 15:17
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@Ocramius Ocramius self-assigned this Mar 23, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants