-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for Renovate with reusable workflows #128
Conversation
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires rolling back to a much smaller composer.lock
change (just hash change)
Hmm, the psalm issues seem to be unrelated: I think the reason for the failures is that We need to add |
psalm.xml
Outdated
@@ -1,6 +1,7 @@ | |||
<?xml version="1.0"?> | |||
<psalm | |||
errorLevel="1" | |||
phpVersion="7.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, wasn't clear - the PHP version should probably be 8.1, which is where psalm is run :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understood that part but got confused because we are still running ci
check on the minimum supported PHP version,PHP 7.4
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm generally confused by the CI output anyway 🤷
Probably need to get back to this at a later point in time, checking it out locally, because those CI failures should really not be there, unless the PHP version changed some details internally too 🤔
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Description
Adding Renovate to Laminas, Mezzio repositories. https://gist.github.com/weierophinney/49ca8ae2b916d898dd3d4162b26ff41b
Continuous Integration
workflowAutomatic Releases
workflow