Pass 0 instead of null to preg_match() $flags, since in PHP 8.1+ the signature may change
#87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander M. Turek <me@derrabus.de>
|
LGTM, but beware that this library does not allow installation with 8.1
yet, so that will be a question for ~ october, when the first RC releases
can be verified
…On Sat, Jun 5, 2021, 11:51 Alexander M. Turek ***@***.***> wrote:
Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no Description
The $flags parameter of preg_match() should be an integer, but
DocBlockScanner passes null when calling the method. PHP 8.1 will be
stricter about that and trigger a deprecation warning. This PR proposes to
pass 0 instead, which is the actual default value of that parameter.
------------------------------
You can view, comment on, or merge this pull request online at:
#87
Commit Summary
- Pass 0 instead of null to preg_match()
File Changes
- *M* src/Scanner/DocBlockScanner.php
<https://github.com/laminas/laminas-code/pull/87/files#diff-c4c83894994b99bcf34e5afcb09abac8d8b0213812beb0ea7df64f0645ebfbbe>
(2)
Patch Links:
- https://github.com/laminas/laminas-code/pull/87.patch
- https://github.com/laminas/laminas-code/pull/87.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#87>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABFVEDCLQM3ZZSQJY65DG3TRHXTLANCNFSM46EK5FIA>
.
|
Ocramius
approved these changes
Jun 17, 2021
Ocramius
changed the title
0 instead of null to preg_match() $flags, since in PHP 8.1+ the signature may change
|
Thanks @derrabus! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
$flagsparameter ofpreg_match()should be an integer, butDocBlockScannerpassesnullwhen calling the method. PHP 8.1 will be stricter about that and trigger a deprecation warning. This PR proposes to pass0instead, which is the actual default value of that parameter.