Fix incorrect argument type when @param is not declared for all parameters of a function

[ihor-sviziev]

Q	A
Documentation	no
Bugfix	yes
BC Break	no
New Feature	no
RFC	no
QA	no

Description

This is a follow-up on magento/magento2#33595 and symfony/symfony#42281.
Magento using laminas/laminas-code as a dependency. It is used especially for retrieving argument types during running the php bin/magento setup:di:compile command.

The root cause analyses showed that inside the module symfony/console was removed the optional @param that declared as argument types. The hotfix was the following - declare all params.

My PR changes behavior from checking only by position to two steps when NOT all arguments have their own argument type defined:

1. Check property by position (the fastest solution)
   • if the variable name is empty (e.g.* @param string) - use return type from it
   • if the variable name is equal to what was requested (e.g.* @param string $myParam) - use return type from it
2. Iterate all @param tags from the phpdoc block and try to find the corresponding variable name. If found - user return type from it

[ihor-sviziev]

@Ocramius I just pushed the changes.
I'm first time contributing to laminas, so not sure if I did everything correctly.
Note: For Magento 2 we need to have 3.5.x release. Should I create a separate PR for that? Or you will port it?

[IbrahimS2]

@ihor-sviziev The datatype should be checked first and if not declared then and only then PHPDocs can be checked.

[ihor-sviziev]

@IbrahimS2, as you can see, it works exactly in this way. The new case is added when NOT all arguments has their own argument type defined.
I update the PR description, in order to make it more clear

[ihor-sviziev]

@Ocramius, could you please review this pull request?

[Ocramius]

Besides minor adjustments, I think this is good to go

[Ocramius]

🚢 thanks @ihor-sviziev!