Use Date facade for storing the password confirmation timestamp
#520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crynobone
added a commit
to laravel/framework
that referenced
this pull request
Jan 28, 2025
This matches the changes via laravel/fortify#520 -------------- Currently, the password confirmation endpoint uses PHP's inbuilt `time()` function. This does not consider `freezeSecond()` or `Date::setTestNow()`. Leading to inconsistent results during tests. This update maintains compatibility with existing features as both `time()` and `->unix()` return a UNIX timestamp. Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
crynobone
pushed a commit
to laravel/framework
that referenced
this pull request
Jan 28, 2025
This matches the changes via laravel/fortify#520 -------------- Currently, the password confirmation endpoint uses PHP's inbuilt `time()` function. This does not consider `freezeSecond()` or `Date::setTestNow()`. Leading to inconsistent results during tests. This update maintains compatibility with existing features as both `time()` and `->unix()` return a UNIX timestamp. Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
taylorotwell
pushed a commit
to laravel/framework
that referenced
this pull request
Jan 28, 2025
…amp (#54383) This matches the changes via laravel/fortify#520 -------------- Currently, the password confirmation endpoint uses PHP's inbuilt `time()` function. This does not consider `freezeSecond()` or `Date::setTestNow()`. Leading to inconsistent results during tests. This update maintains compatibility with existing features as both `time()` and `->unix()` return a UNIX timestamp. Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> Co-authored-by: Chris van Lier <93382176+chrisvanlier2005@users.noreply.github.com>
taylorotwell
pushed a commit
to illuminate/session
that referenced
this pull request
Jan 28, 2025
…amp (#54383) This matches the changes via laravel/fortify#520 -------------- Currently, the password confirmation endpoint uses PHP's inbuilt `time()` function. This does not consider `freezeSecond()` or `Date::setTestNow()`. Leading to inconsistent results during tests. This update maintains compatibility with existing features as both `time()` and `->unix()` return a UNIX timestamp. Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> Co-authored-by: Chris van Lier <93382176+chrisvanlier2005@users.noreply.github.com>
taylorotwell
pushed a commit
to illuminate/support
that referenced
this pull request
Jan 28, 2025
…amp (#54383) This matches the changes via laravel/fortify#520 -------------- Currently, the password confirmation endpoint uses PHP's inbuilt `time()` function. This does not consider `freezeSecond()` or `Date::setTestNow()`. Leading to inconsistent results during tests. This update maintains compatibility with existing features as both `time()` and `->unix()` return a UNIX timestamp. Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> Co-authored-by: Chris van Lier <93382176+chrisvanlier2005@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the password confirmation endpoint uses PHP's inbuilt
time()function. This does not considerfreezeSecond()orDate::setTestNow(). Leading to inconsistent results during tests.Compatibility
This update maintains compatibility with existing features as both
time()and->unix()return a UNIX timestamp.