[11.x] Check if the running Symfony process has timed out #54903
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix checks for timeouts when a process is running.
Consider the following example from the documentation:
This uses the
wait
method from Symfony'sProcess
which includes a call tocheckTimeout
that throwsProcessTimedOutException
which the framework catches and reports back.Compared to this example from the documentation:
This uses the
isRunning
method from Symfony'sProcess
which doesn't ever callcheckTimeout
. The loop will never catch any timeouts.If this change is too breaking, maybe instead exposing the
checkTimeout
method and adding a note to the docs so developers know to make this check themselves in theirwhile
loop ?