Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ValidationEmailRuleTest skips tests requiring the intl extension when unavailable #54918

Merged
merged 1 commit into from
Mar 6, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/Validation/ValidationEmailRuleTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
use Illuminate\Validation\Rules\Email;
use Illuminate\Validation\ValidationServiceProvider;
use Illuminate\Validation\Validator;
use PHPUnit\Framework\Attributes\RequiresPhpExtension;
use PHPUnit\Framework\Attributes\TestWith;
use PHPUnit\Framework\TestCase;

Expand Down Expand Up @@ -143,6 +144,7 @@ public function testRfcCompliantStrict()
);
}

#[RequiresPhpExtension('intl')]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to import the class

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

public function testValidateMxRecord()
{
$this->fails(
Expand Down Expand Up @@ -674,6 +676,7 @@ public function testEmailsThatFailBothNativeValidationAndRfcCompliantStrict($ema
);
}

#[RequiresPhpExtension('intl')]
public function testCombiningRules()
{
$this->passes(
Expand Down
Loading