[12.x] Add test coverage for Uri::withQueryIfMissing method #54923
+62
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test verifies that the withQueryIfMissing method adds parameters only when they don't exist while preserving the values of existing parameters.
This commit adds cases for complex nested arrays and indexed arrays to ensure the method correctly handles multi-dimensional data structures in query parameters.
mohammadrasoulasghari
force-pushed
the
feature/test-uri-with-query-if-missing
branch
from
d04a8a0 to
a536748
Compare
This commit finalizes tests for the withQueryIfMissing method, covering: - Partial merging of associative arrays - Preservation of indexed arrays - Verification of both encoded query strings and parsed arrays
mohammadrasoulasghari
force-pushed
the
feature/test-uri-with-query-if-missing
branch
from
a536748 to
15a4490
Compare
mohammadrasoulasghari
force-pushed
the
feature/test-uri-with-query-if-missing
branch
from
d13ea28 to
218c5e6
Compare
|
Also added complete PHPDoc annotation for the withQueryIfMissing method. 📝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test coverage for Uri::withQueryIfMissing method
This PR adds test coverage for the withQueryIfMissing method which previously had no tests. The test suite covers the following scenarios:
🔹 Adding new parameters while preserving existing ones with simple key-value pairs
🔹 Adding complex nested arrays to an empty query string with both associative and indexed arrays
🔹 Merging partial arrays while preserving existing values at the top level
🔹 Handling indexed arrays correctly by preserving them as complete entities
🔹 Adding missing nested properties in associative arrays while keeping existing ones intact
🔹 Verifying both the encoded query string format and the parsed array structure
🛡️These tests ensure that withQueryIfMissing correctly adds parameters only when they don't exist in the original URI, preserves all existing values regardless of the hierarchy level, and properly handles both simple and complex data structures in query parameters.🚀