[12.x] Types: Collection chunk without preserving keys #54924
+21
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamduckett
changed the title
GrahamCampbell
requested changes
Mar 6, 2025
| @@ -1442,7 +1442,7 @@ public function firstOrFail($key = null, $operator = null, $value = null) | |||
| * | |||
| * @param int $size | |||
| * @param bool $preserveKeys | |||
| * @return static<int, static> | |||
| * @return ($preserveKeys is true ? static<int, static> : static<int, static<int, TValue>>) | |||
There was a problem hiding this comment.
Is this syntax supported by both psalm and phpstan?
There was a problem hiding this comment.
Hey, yeah:
It's not new to the framework either:
framework/src/Illuminate/Support/helpers.php
Line 415 in 77672fd
|
@liamduckett does this work with VS Code? |
|
@taylorotwell it does for me - I do have the PHP Intelephense extension though? Edit: sorry forgot to attach screenshots...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, realised #54916 needs some slight type tweaks - added type tests accordingly.
I understand it to still adhere to the
Enumerableinterface, asstatic<int, static<int, TValue>>is a subtype ofstatic<int, static>(which is implicitlystatic<int, static<TKey, TValue>>) asTKeyis covariant.