-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make() quick access #61
Conversation
👍 Good idea, i was looking for something similar yesterday |
I remember seeing a pull request like this in one of the Illuminate components, and it was rejected, I think. |
Just proves that there are people who like this. We'll see |
I can't help but notice you're saving like, six characters here. If it's the |
No it's not unclean. But app('path') just seems to be smarter and cleaner than app()->make('path) |
Just an idea: For consistency when adding features, etc... it would be good for the contributor to directly add an associated (with a reference) pull request to the documentation. That would keep docs in sync with the code-base. |
Good idea but there's actually no place for helpers on the docs. IoC doesn't include app() as well. |
@zimt28 After a PR on the codebase has been merged, the contributor can do a pull request with the associated doc updates. That's the way to go, I think. EDIT: Oh... now I got "no place for helpers" :D More coffee please!! Maybe Taylor can introduce something? |
Add full() and current() url methods
This will save some unneeded lines of code but keep readability. Though doesn't force anyone to use it.