Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make() quick access #61

Merged
merged 2 commits into from
Jan 15, 2013
Merged

make() quick access #61

merged 2 commits into from
Jan 15, 2013

Conversation

zimt28
Copy link
Contributor

@zimt28 zimt28 commented Jan 15, 2013

This will save some unneeded lines of code but keep readability. Though doesn't force anyone to use it.

@onigoetz
Copy link
Contributor

👍 Good idea, i was looking for something similar yesterday

@franzliedke
Copy link
Contributor

I remember seeing a pull request like this in one of the Illuminate components, and it was rejected, I think.

@zimt28
Copy link
Contributor Author

zimt28 commented Jan 15, 2013

Just proves that there are people who like this. We'll see

@Anahkiasen
Copy link
Contributor

I can't help but notice you're saving like, six characters here. If it's the -> you find unclean you can do the same thing with  App::make which looks cleaner in the code.

@zimt28
Copy link
Contributor Author

zimt28 commented Jan 15, 2013

No it's not unclean. But app('path') just seems to be smarter and cleaner than app()->make('path)

taylorotwell added a commit that referenced this pull request Jan 15, 2013
@taylorotwell taylorotwell merged commit 27ed747 into laravel:master Jan 15, 2013
@frankmayer
Copy link

Just an idea: For consistency when adding features, etc... it would be good for the contributor to directly add an associated (with a reference) pull request to the documentation. That would keep docs in sync with the code-base.
Thanks :)

@zimt28
Copy link
Contributor Author

zimt28 commented Jan 16, 2013

Good idea but there's actually no place for helpers on the docs. IoC doesn't include app() as well.

@frankmayer
Copy link

@zimt28 After a PR on the codebase has been merged, the contributor can do a pull request with the associated doc updates. That's the way to go, I think.
What's your take on this @taylorotwell ? I believe that this should maybe also be included in the contribution document, as a "would be much appreciated" task. :D

EDIT: Oh... now I got "no place for helpers" :D More coffee please!! Maybe Taylor can introduce something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants