Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow build with no additional services #19

Merged
merged 3 commits into from
Jun 2, 2023

Conversation

askmrsinh
Copy link
Contributor

@askmrsinh askmrsinh commented Jun 1, 2023

Allows for the use of --with=none option e.g. php ./artisan sail:install --with=none. Please see: laravel/sail#495 & this.

PR to Update Sail Server documentation: laravel/docs#8831

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

@taylorotwell taylorotwell reopened this Jun 2, 2023
@taylorotwell taylorotwell merged commit 1083d30 into laravel:master Jun 2, 2023
@askmrsinh
Copy link
Contributor Author

askmrsinh commented Jun 2, 2023

@taylorotwell Thanks for merging this. I see that the sibling PR laravel/docs#8831 was closed. Do you not wish to advertise this option to doc readers?

Just to clarify, this PR addressed a gap. Now, users can have a minimal Laravel project configured with Sail by:

curl -s "https://laravel.build/example-app?with=none" | bash

Which translates to Laravel Sail command:

php ./artisan sail:install --with=none

Laravel Sail package has supported --with=none for quite some time now. This PR just exposes it when creating projects via the sail server (laravel.build).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants