Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laravel Sail installation in the project fails when using --with=none #492

Closed
jf-prevost opened this issue Nov 19, 2022 · 4 comments · Fixed by #495
Closed

Laravel Sail installation in the project fails when using --with=none #492

jf-prevost opened this issue Nov 19, 2022 · 4 comments · Fixed by #495
Labels
help wanted

Comments

@jf-prevost
Copy link
Contributor

jf-prevost commented Nov 19, 2022 •
edited
Loading

  • Sail Version: v1.16.2
  • Laravel Version: v9.3.11
  • PHP Version: 8.1.11
  • Host operating system: Linux Debian 10.13

Description:

in a fresh Laravel project, doing a "php artisan sail:install --with=none" fails when trying to pull empty services

Steps To Reproduce:

$ laravel new testproject && cd testproject
$ php artisan sail:install --with=none
Sail scaffolding installed successfully.
Pulling laravel.test ... error

ERROR: for laravel.test  Get "https://sail-8.1/v2/": dial tcp: lookup sail-8.1 on <dns_resolver_ip>:53: no such host
ERROR: Get "https://sail-8.1/v2/": dial tcp: lookup sail-8.1 on <dns_resolver_ip>:53: no such host

Note: when commenting out line 224 of vendor/laravel/sail/src/Console/InstallCommand.php
'./vendor/bin/sail pull '.implode(' ', $services),
thus bypassing the pull phase, everything runs fine.

--with=none option should be handled properly to allow the setup of Sail with no additional feature.
@driesvints
Copy link
Member

Hmm this is a more a feature request. Feel free to send in a PR 👍

@jf-prevost
Copy link
Contributor Author

Hmm this is a more a feature request. Feel free to send in a PR 👍

Well, actually in the code the --with option handles the case of 'none'. So that feature is already present but alas not correctly handled.

@driesvints
Copy link
Member

I see. Nevertheless we'd appreciate a PR.

@driesvints driesvints reopened this Nov 19, 2022
@jf-prevost jf-prevost mentioned this issue Nov 19, 2022
Closed
@jf-prevost
Copy link
Contributor Author

@driesvints I proposed a fix in a PR but was closed without merge. Any tip on how to solve this ?

@driesvints driesvints linked a pull request Nov 21, 2022 that will close this issue
Fix usage of none for services list #495
Merged
taylorotwell added a commit that referenced this issue Nov 21, 2022
@jf-prevost @driesvints @taylorotwell
Fix usage of none for services list (#495)
0dbee88 
* fix issue #492

php artisan sail:install --with=none not handled properly

* Update InstallCommand.php

* formatting

Co-authored-by: Dries Vints <dries@vints.io>
Co-authored-by: Taylor Otwell <taylor@laravel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix usage of none for services list
2 participants
@driesvints @jf-prevost