Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install regular PHP packages instead of dev versions #340

Merged
merged 4 commits into from
Feb 17, 2022
Merged

Install regular PHP packages instead of dev versions #340

merged 4 commits into from
Feb 17, 2022

Conversation

bramdevries
Copy link
Contributor

Currently when setting up the project using the PHP 8.0 runtime it actually installs PHP8.1, which leads to certain modules not being installed (such as #338)

Instead using php8.0 will correctly install PHP 8.0.

@driesvints
Copy link
Member

Putting this in draft while I talk over things with Taylor.

@driesvints driesvints marked this pull request as draft February 17, 2022 13:29
@taylorotwell
Copy link
Member

I really want to get a better understanding of why this is happening. Does anyone know?

@driesvints
Copy link
Member

We found out btw: oerdnj/deb.sury.org#1711

We've decided to convert all of these to the regular versions instead of the -dev versions. Thanks @bramdevries

@driesvints driesvints marked this pull request as ready for review February 17, 2022 15:03
@taylorotwell taylorotwell merged commit 90b27e3 into laravel:1.x Feb 17, 2022
@driesvints driesvints changed the title Install PHP8.0 instead php8.0-dev Install regular PHP packages instead of dev versions Feb 17, 2022
taylorotwell added a commit that referenced this pull request Feb 17, 2022
taylorotwell added a commit that referenced this pull request Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants