Fix SAIL_SHARE_DOMAIN
default value
#546
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests provides a default value for
SAIL_SHARE_DOMAIN
fixing the issue #545If the value of
SAIL_SHARE_DOMAIN
is not set, it will get the value fromSAIL_SHARE_SERVER_HOST
, which by default islaravel-sail.site
, recovering the original behaviour in version1.18.1
, before the commit 8c9d836, and therefore fixing the issue mention above where the public shared hostname has only the autogenerated subdomain.