Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SAIL_SHARE_DOMAIN default value #546

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Fix SAIL_SHARE_DOMAIN default value #546

merged 1 commit into from
Feb 8, 2023

Conversation

gonzalom
Copy link
Contributor

@gonzalom gonzalom commented Feb 8, 2023

This pull requests provides a default value for SAIL_SHARE_DOMAIN fixing the issue #545

If the value of SAIL_SHARE_DOMAIN is not set, it will get the value from SAIL_SHARE_SERVER_HOST, which by default is laravel-sail.site, recovering the original behaviour in version 1.18.1, before the commit 8c9d836, and therefore fixing the issue mention above where the public shared hostname has only the autogenerated subdomain.

$ sail share
Thank you for using expose.
Shared URL:		host.docker.internal:80
Dashboard:		http://127.0.0.1:4040
Public HTTP:		http://ahirytx7qj.:8080
Public HTTPS:		https://ahirytx7qj.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants