Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add inplace conversion support for f8_e4m3 #359

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Conversation

Green-Sky
Copy link
Contributor

In the same way it is done for bf16.
Like how bf16 converts losslessly to fp32, f8_e4m3 converts losslessly to fp16.

(merge base right now is flux, @leejet tell me if I should retarget onto master)

in the same way it is done for bf16
like how bf16 converts losslessly to fp32,
f8_e4m3 converts losslessly to fp16
@leejet
Copy link
Owner

leejet commented Aug 24, 2024

Thank you for your contribution

@leejet leejet merged commit d8c65b4 into leejet:flux Aug 24, 2024
9 checks passed
SkutteOleg pushed a commit to SkutteOleg/stable-diffusion.cpp that referenced this pull request Aug 24, 2024
in the same way it is done for bf16
like how bf16 converts losslessly to fp32,
f8_e4m3 converts losslessly to fp16
leejet added a commit that referenced this pull request Aug 24, 2024
* add flux support

* avoid build failures in non-CUDA environments

* fix schnell support

* add k quants support

* add support for applying lora to quantized tensors

* add inplace conversion support for f8_e4m3 (#359)

in the same way it is done for bf16
like how bf16 converts losslessly to fp32,
f8_e4m3 converts losslessly to fp16

* add xlabs flux comfy converted lora support

* update docs

---------

Co-authored-by: Erik Scholz <Green-Sky@users.noreply.github.com>
SkutteOleg pushed a commit to SkutteOleg/stable-diffusion.cpp that referenced this pull request Aug 24, 2024
in the same way it is done for bf16
like how bf16 converts losslessly to fp32,
f8_e4m3 converts losslessly to fp16
@Green-Sky Green-Sky deleted the f8_e4m3 branch November 23, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants