Yann/feature/lekaupdater/update process v150 #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladislas
requested changes
May 13, 2024
Apps/LekaUpdater/Sources/Libs/UpdateProcess/Version/UpdateProcessV150.swift
Outdated
Show resolved
Hide resolved
YannLocatelli
force-pushed
the
yann/feature/lekaupdater/update-process-v150
branch
from
5e8cb43 to
78be033
Compare
YannLocatelli
force-pushed
the
yann/feature/lekaupdater/update-process-v150
branch
3 times, most recently
from
10dbacb to
1668a82
Compare
YannLocatelli
force-pushed
the
yann/feature/lekaupdater/update-process-v150
branch
2 times, most recently
from
3916845 to
b7b3ae6
Compare
ladislas
requested changes
Jun 11, 2024
Comment on lines
242
to
255
| Robot.shared.connectedPeripheral?.peripheral.readValue(forCharacteristic: BLESpecs.Monitoring.Characteristics.negotiatedMTU, inService: BLESpecs.Monitoring.service) | ||
| .receive(on: DispatchQueue.main) | ||
| .sink( | ||
| receiveCompletion: { _ in | ||
| // nothing to do | ||
| }, | ||
| receiveValue: { data in | ||
| if let data { | ||
| self.maximumPacketSize = Int(data.map { UInt16($0) }.reduce(0) { $0 << 8 + $1 }) - self.l2capOverhead | ||
| self.sendFile() | ||
| } | ||
| } | ||
| ) | ||
| .store(in: &self.cancellables) |
There was a problem hiding this comment.
la logique me va, en revanche l'information du MTU est intéressante à plein d'égard pour d'autres endroits de nos applications, par exemple pour générer les commandes.
il faut donc plutôt remonter l'information du côté de RobotKit en ajoutant cela dans Robot.swift
public var negotiatedMTU: CurrentValueSubject<Int, Never> = CurrentValueSubject(0)et une fonction de register type
func registerNegotiatedMTUNotificationCallback() {
// ...
}
Apps/LekaUpdater/Sources/Libs/UpdateProcess/Version/UpdateProcessV150.swift
Show resolved
Hide resolved
This was referenced Jun 11, 2024
YannLocatelli
force-pushed
the
yann/feature/lekaupdater/update-process-v150
branch
2 times, most recently
from
b297865 to
d782cbd
Compare
Copied from UpdateProcessV130
182 is the max value possible on iOS device, indeed 185 is the max MTU and the header is always 3 bytes long, so each packet has a limit of 182 bytes
YannLocatelli
force-pushed
the
yann/feature/lekaupdater/update-process-v150
branch
from
d782cbd to
7d7b7e0
Compare
|
ladislas
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.