Fix no traces getting sent on macOS #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, this change is absolutely baffling why it fixes the bug, but it does. I think that what happened is that even though both /run/current-system/sw/bin/nix and the nix used by the flake are 2.11, we are still doing some kind of ABI crimes. It seems that some kind of macOS shenanigans means that our copy of the nix::logger symbol is different than the one that Nix is using because of this. The solution here is to *ensure* that the nix you call the plugin with is the same nix as it was built with, which we probably should have been doing in the first place anyway!
Gabriella439
approved these changes
Nov 14, 2022
| @@ -33,6 +33,7 @@ | |||
| # any dev tools you use in excess of the rust ones | |||
| nativeBuildInputs = old.nativeBuildInputs ++ ( | |||
| with pkgs; [ | |||
| nix | |||
There was a problem hiding this comment.
I think this would only fix the plugin in the context of the shell, so you probably want to also mention this restriction in the README in case the user wants to use it outside the shell (or patch in their own Nix version). However, this will be good enough for me
johnrichardrinehart
pushed a commit
to johnrichardrinehart/nix-otel
that referenced
this pull request
Oct 29, 2023
Symlink libcuda.so.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yes, this change is absolutely baffling why it fixes the bug, but it does. I think that what happened is that even though both
/run/current-system/sw/bin/nix and the nix used by the flake are 2.11, we are still doing some kind of ABI crimes.
It seems that some kind of macOS shenanigans means that our copy of the nix::logger symbol is different than the one that Nix is using because of this, so the logger never gets overridden and we get no data.
The solution here is to ensure that the nix you call the plugin with is the same nix as it was built with, which we probably should have been doing in the first place anyway!