This repository was archived by the owner on May 12, 2021. It is now read-only.
Add Go module support #40
Merged
+291
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@anacrolix PR was opened 25 days ago. Have any deps changed since then? |
License: MIT Signed-off-by: Matt Joiner <anacrolix@gmail.com>
License: MIT Signed-off-by: Matt Joiner <anacrolix@gmail.com>
License: MIT Signed-off-by: Matt Joiner <anacrolix@gmail.com>
|
@raulk No they haven't (just tested). A future PR can include CI for go mod support. |
anacrolix
force-pushed
the
feat/go.mod
branch
from
89ae0bb to
aa09497
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like a good opportunity to add and demonstrate the Go module turd files, as currently this repo will not be go-gettable until libp2p/go-reuseport-transport#6 is merged. There's also no gx for this repo to contend with. The added go.mod files include go-reuseport wasm support without using the unmerged PR to go-reuseport-transport.
Users can (with Go 1.11) install all the binaries for example with
GO111MODULE=on go install -v ./...from the repo root, and test wasm build compat withGO111MODULE=on GOOS=js GOARCH=wasm go test ./....