Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(put): fail if any router fails #19

Merged
merged 2 commits into from
Mar 2, 2019
Merged

fix(put): fail if any router fails #19

merged 2 commits into from
Mar 2, 2019

Conversation

Stebalien
Copy link
Member

That way, we don't succeed if, e.g., publishing to pubsub succeeds but the DHT
fails.

@ghost ghost assigned Stebalien Mar 1, 2019
@ghost ghost added the status/in-progress In progress label Mar 1, 2019
@Stebalien Stebalien mentioned this pull request Mar 1, 2019
Merged
@Stebalien Stebalien requested a review from vyzo March 1, 2019 22:55
raulk
raulk approved these changes Mar 1, 2019
View reviewed changes
Copy link
Member

@raulk raulk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch LGTM, although I expected this change would imply a change in a test too. Not this PRs fault that we’re missing coverage though. Are we the only ones using this? Isn’t there a risk that this change in behaviour affects others?

@Stebalien
Copy link
Member Author

We are the only ones using this and yeah, this should be tested... Test coverage is a LIE!

@Stebalien
Copy link
Member Author

(tested)

@Stebalien Stebalien merged commit 19d74b1 into master Mar 2, 2019
@ghost ghost removed the status/in-progress In progress label Mar 2, 2019
@Stebalien Stebalien deleted the fix/put-require-all branch March 2, 2019 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulk raulk raulk approved these changes

@vyzo vyzo Awaiting requested review from vyzo

Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @raulk