-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: introduce rustfmt.toml
#5686
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,16 +28,17 @@ | |
//! to a remote and can subdivide this connection into multiple substreams. | ||
//! See the [`muxing`] module. | ||
//! - The [`UpgradeInfo`], [`InboundUpgrade`] and [`OutboundUpgrade`] traits | ||
//! define how to upgrade each individual substream to use a protocol. | ||
//! See the `upgrade` module. | ||
//! define how to upgrade each individual substream to use a protocol. See the | ||
//! `upgrade` module. | ||
#![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))] | ||
|
||
mod proto { | ||
#![allow(unreachable_pub)] | ||
include!("generated/mod.rs"); | ||
pub use self::{ | ||
envelope_proto::*, peer_record_proto::mod_PeerRecord::*, peer_record_proto::PeerRecord, | ||
envelope_proto::*, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. since we are on this, is there a way to impede There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
aah no, not using the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. however there's a clippy lint config There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok nice, yeah we can submit another PR with it enabled |
||
peer_record_proto::{mod_PeerRecord::*, PeerRecord}, | ||
}; | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we not break here, and therefore not diff on these situations? I think it's what @drHuangMHT was mentioning also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I can control the output of the diff here, but I don't see huge downside of this. lmk wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's just
cargo +nightly fmt
on the codebase after adding therustfmt.toml
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's the
imports_layout
rule, can you test withLimitedHorizontalVertical
? see here and here for more info