Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-135072 Upgrade package version #1283

Closed
wants to merge 1 commit into from
Closed

LPS-135072 Upgrade package version #1283

wants to merge 1 commit into from

Conversation

edalgrin
Copy link
Collaborator

@edalgrin edalgrin commented Jul 26, 2021 •
edited
Loading

This PR is the second part of liferay/alloy-font-awesome#4
it removes legacy code that is causing a performance issue with a client

The tests confirm that the removal is working properly
image

@liferay-continuous-integration
Copy link
Collaborator

Please only forward critical changes to Brian Chan during stabilization. Nonurgent changes should wait until the ongoing 7.4 DXP EP3 & CE GA3 release has been completed. For more details on the release timeline and status, see product-delivery.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

@edalgrin edalgrin mentioned this pull request Jul 26, 2021
Merged
@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: cbc7d236d8884c9691a22306c6e7e8aca3f58ce5

Sender Branch:

Branch Name: LPS-135072
Branch GIT ID: 1ef787379956a4efcfc791a88e323904875fb295

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@edalgrin
Copy link
Collaborator Author

edalgrin commented Jul 26, 2021 •
edited
Loading

I'm not sure if we need to upgrade https://github.com/liferay/liferay-portal/blob/master/modules/yarn.lock#L9564 Well, I did it 😄

@liferay-continuous-integration
Copy link
Collaborator

@edalgrin
Copy link
Collaborator Author

Not sure if we need to update this folder as a package https://www.npmjs.com/package/frontend-theme-font-awesome-web

@javiergamarra
Copy link

Not sure if we need to update this folder as a package https://www.npmjs.com/package/frontend-theme-font-awesome-web

Looks like we don't:

This package is not intended to be consumed directly; please see https://github.com/liferay/liferay-portal/blob/master/modules/apps/frontend-theme/frontend-theme-font-awesome-web

@edalgrin
Copy link
Collaborator Author

edalgrin commented Aug 2, 2021

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 22 out of 22 jobs passed in 1 hour 58 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 7cb912889719a27e3dff73a0501155c0f36610f9

Upstream Comparison:

Branch GIT ID: 7cb912889719a27e3dff73a0501155c0f36610f9
Jenkins Build URL: Acceptance Upstream DXP (master) #2168

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 22 out of 22 jobs PASSED
22 Successful Jobs:
For more details click here.
Test bundle downloads:

@javiergamarra
Copy link

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

@edalgrin
Copy link
Collaborator Author

edalgrin commented Aug 3, 2021

ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d75a749f503bcaa193680fefda7da441807476a3

Sender Branch:

Branch Name: LPS-135072
Branch GIT ID: 3432c199abd419bdf4a865d2cd6fce76e0ae8f5b

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@edalgrin
Copy link
Collaborator Author

edalgrin commented Aug 3, 2021

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

@liferay-continuous-integration liferay-continuous-integration mentioned this pull request Aug 3, 2021
Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#105045
Console

@liferay-continuous-integration
Copy link
Collaborator

@edalgrin edalgrin deleted the LPS-135072 branch August 12, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markocikos markocikos markocikos left review comments

@javiergamarra javiergamarra javiergamarra approved these changes

Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edalgrin @liferay-continuous-integration @javiergamarra @markocikos