Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace feets with cesium for tests #459

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Replace feets with cesium for tests #459

merged 1 commit into from
Dec 6, 2024

Conversation

hombit
Copy link
Member

@hombit hombit commented Dec 5, 2024

Fix #424 #366

@hombit hombit enabled auto-merge December 5, 2024 22:51
@hombit hombit disabled auto-merge December 5, 2024 22:52
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.06%. Comparing base (3820cd9) to head (413bb36).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #459   +/-   ##
=======================================
  Coverage   82.06%   82.06%           
=======================================
  Files           9        9           
  Lines        2576     2576           
=======================================
  Hits         2114     2114           
  Misses        462      462           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 5, 2024

CodSpeed Performance Report

Merging #459 will improve performances by 19.01%

Comparing cesium (413bb36) with master (3820cd9)

Summary

⚡ 1 improvements
✅ 79 untouched benchmarks
🆕 24 new benchmarks
⁉️ 19 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master cesium Change
🆕 test_benchmark_cesium N/A 13 ms N/A
🆕 test_benchmark_rust N/A 296.8 µs N/A
⁉️ test_benchmark_feets 8 ms N/A N/A
⁉️ test_benchmark_rust 321 µs N/A N/A
🆕 test_benchmark_cesium N/A 5.6 ms N/A
🆕 test_benchmark_cesium N/A 6.6 ms N/A
⁉️ test_benchmark_feets 1.5 ms N/A N/A
🆕 test_benchmark_cesium N/A 5.7 ms N/A
⁉️ test_benchmark_feets 687.4 µs N/A N/A
⁉️ test_benchmark_feets 328.2 µs N/A N/A
⁉️ test_benchmark_feets 1.2 ms N/A N/A
test_benchmark_lc_py 330.6 µs 277.8 µs +19.01%
⁉️ test_benchmark_feets 644.4 µs N/A N/A
⁉️ test_benchmark_feets 796.1 µs N/A N/A
⁉️ test_benchmark_feets 2.2 ms N/A N/A
🆕 test_benchmark_cesium N/A 5.6 ms N/A
🆕 test_benchmark_lc_py N/A 436.5 µs N/A
🆕 test_benchmark_rust N/A 96.2 µs N/A
🆕 test_benchmark_cesium N/A 5.6 ms N/A
🆕 test_benchmark_lc_py N/A 435.3 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@hombit hombit force-pushed the cesium branch 2 times, most recently from 42a4a8d to 30528c4 Compare December 6, 2024 14:02
@hombit hombit merged commit 55b6df2 into master Dec 6, 2024
51 of 52 checks passed
@hombit hombit deleted the cesium branch December 6, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove feets package (test dependency)
1 participant