Fix creating static forwarders for inherited methods #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reproducing #154
We should create static forwarders for the methods inherited on the companion object, not on the class itself.
raboof
force-pushed
the
fixDispatcherSelector
branch
from
fab3420 to
787ce48
Compare
|
I just confirmed this change fixed #154 in the Akka build, though other problems remain. I'll address those in separate PR's. |
raboof
changed the title
raboof
force-pushed
the
fixDispatcherSelector
branch
3 times, most recently
from
f51b546 to
4da3f08
Compare
raboof
changed the title
raboof
force-pushed
the
fixDispatcherSelector
branch
from
4da3f08 to
c679b23
Compare
patriknw
approved these changes
Dec 13, 2018
| // not preceding | ||
| public Identify (Object messageId) { throw new RuntimeException(); } | ||
| public akka.actor.Identify copy (Object messageId) { throw new RuntimeException(); } | ||
| public Object copy$default$1 () { throw new RuntimeException(); } |
There was a problem hiding this comment.
a nice thing for the future could be to completely filter out Scala stuff that's not intended to be public Java API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should create static forwarders for the methods inherited on the
companion object, not on the class itself.
Fixes #154