-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to support M1 architecture #99
Comments
One more step is some details about building the docker image using |
Adding that osx-x86_64 then goes on to fail with
in "cpu_features" google/cpu_features#150 So looks like moving forward with this is blocked by that |
Looks like this may be fixed by the switch in what proto/grpc tooling we use in current main. |
Almost, it is not possible to build the kalix-tools because it depends on a native image of the codegen which is not available for Macos arm64. |
I got that to work locally by doing the following:
|
Looks like CircleCI doesn't yet support M1, so we won't be able to automate this yet. https://circleci.canny.io/cloud-feature-requests/p/support-new-m1-arm-based-macs Can it just run the x64 codegen binary via rosetta for now? (don't have an M1 mac to try it out) Looks like there are protoc versions with osx-aarch downloads now. Will |
Longer term, could make more sense to convert the codegen over to TypeScript, and not have the native image binaries. |
Published |
Looks like 1.0.0-M9 works nicely up to building a docker image. Building the image needs a cross build using buildx (this is how I've solved that in the Scala SDK samples: https://github.com/lightbend/kalix-jvm-sdk/blob/main/samples/scala-doc-snippets/build.sbt#L18 ), or you end up with an arm64 image on docker hub which can't be deployed to Kalix. |
For the record, this is the command to cross-build and push the js-customer-registry sample:
|
We can include that in the |
Once #377 is merged this now works all the way from creating a project from a template to deploying it |
Currently the install fails when using on M1 architecture Macs but the current fix is pretty straight forward:
Based on issue protocolbuffers/protobuf#8557
We should be able to add these lines and might want to reference the above PR in comments.
The change should be added in this block --
https://github.com/lightbend/akkaserverless-javascript-sdk/blob/69f5578a000b990d02d685ffcf8514e89d985e48/sdk/bin/download-protoc.js#L17
The text was updated successfully, but these errors were encountered: