Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider whether to support looping payments #292

Closed
tnull opened this issue May 14, 2024 · 1 comment
Closed

Consider whether to support looping payments #292

tnull opened this issue May 14, 2024 · 1 comment

Comments

@tnull
Copy link
Collaborator

tnull commented May 14, 2024

A user encountered a case where they wanted to pay a JIT-channel invoice generated by ourselves to trigger a channel open from an LSP (Voltage Flow 2.0 in this case).

However, LDK Node rejected the payment with an NodeError: DuplicatePayment: A payment with the given hash has already been initiated error.

Generally, this is may be considered a misuse of JIT channels as they are really 'just-in-time' and not meant to order (and self-pay) liquidity upfront.
While looping payments are kind of bogus, we still should consider if we need to support them if users keep running into similar issues.

@tnull
Copy link
Collaborator Author

tnull commented Jun 17, 2024

After #308 we're going to reject circular payments with a dedicated error method.

Going forward, given that this directly conflicts with short-circuiting self-payments (cf. lightningdevkit/rust-lightning#2462), we're likely not going to support looping/circular payments. Closing as not planned.

@tnull tnull closed this as not planned Won't fix, can't repro, duplicate, stale Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant