Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow self-payment #2462

Open
TheBlueMatt opened this issue Jul 29, 2023 · 2 comments
Open

Allow self-payment #2462

TheBlueMatt opened this issue Jul 29, 2023 · 2 comments
Milestone
0.2

Comments

@TheBlueMatt
Copy link
Collaborator

Shouldn't be too hard, really, just have to have a length-one route to ourselves with a dummy SCID (zero?) generated by the router. Then if we see it we immediately generate a PaymentSent and PaymentReceived event and put it in the outbound payment set as fulfilled. We'll have to think a bit about how to ensure persistence is guaranteed but maybe we just handwave that away for now and rely on the user checking the pending payment set and seeing it missing?
@TheBlueMatt TheBlueMatt added this to the 0.1.1 milestone Jul 29, 2023
@wpaulino wpaulino mentioned this issue Aug 15, 2023
Closed
@vladimirfomene
Copy link
Contributor

@TheBlueMatt let me take this issue

@TheBlueMatt
Copy link
Collaborator Author

Go for it.

vladimirfomene added a commit to vladimirfomene/rust-lightning that referenced this issue Sep 13, 2023
@vladimirfomene
feat: allow self payment
8900886 
This PR solves issue lightningdevkit#2462. If we asked to
pay an invoice that we generated ourselves. We
generate PaymentSent and PaymentClaimable event
and mark the payment as fulfilled in our set
of outbound payments.

This PR is important because we realized users
can easily screw up self payments when they implement
it themselves. See here: https://lists.linuxfoundation.org/pipermail/lightning-dev/2023-June/003983.html
@vladimirfomene vladimirfomene mentioned this issue Sep 13, 2023
Open
vladimirfomene added a commit to vladimirfomene/rust-lightning that referenced this issue Sep 18, 2023
@vladimirfomene
feat: allow self payment
103b879 
This PR solves issue lightningdevkit#2462. If we asked to
pay an invoice that we generated ourselves. We
generate PaymentSent and PaymentClaimable event
and mark the payment as fulfilled in our set
of outbound payments.

This PR is important because we realized users
can easily screw up self payments when they implement
it themselves. See here: https://lists.linuxfoundation.org/pipermail/lightning-dev/2023-June/003983.html
vladimirfomene added a commit to vladimirfomene/rust-lightning that referenced this issue Sep 18, 2023
@vladimirfomene
feat: allow self payment
1492979 
This PR solves issue lightningdevkit#2462. If we asked to
pay an invoice that we generated ourselves. We
generate PaymentSent and PaymentClaimable event
and mark the payment as fulfilled in our set
of outbound payments.

This PR is important because we realized users
can easily screw up self payments when they implement
it themselves. See here: https://lists.linuxfoundation.org/pipermail/lightning-dev/2023-June/003983.html
vladimirfomene added a commit to vladimirfomene/rust-lightning that referenced this issue Sep 18, 2023
@vladimirfomene
feat: allow self payment
34c5922 
This PR solves issue lightningdevkit#2462. If we asked to
pay an invoice that we generated ourselves. We
generate PaymentSent and PaymentClaimable event
and mark the payment as fulfilled in our set
of outbound payments.

This PR is important because we realized users
can easily screw up self payments when they implement
it themselves. See here: https://lists.linuxfoundation.org/pipermail/lightning-dev/2023-June/003983.html
vladimirfomene added a commit to vladimirfomene/rust-lightning that referenced this issue Sep 19, 2023
@vladimirfomene
feat: allow self payment
d21394e 
This PR solves issue lightningdevkit#2462. If we asked to
pay an invoice that we generated ourselves. We
generate PaymentSent and PaymentClaimable event
and mark the payment as fulfilled in our set
of outbound payments.

This PR is important because we realized users
can easily screw up self payments when they implement
it themselves. See here: https://lists.linuxfoundation.org/pipermail/lightning-dev/2023-June/003983.html
vladimirfomene added a commit to vladimirfomene/rust-lightning that referenced this issue Sep 21, 2023
@vladimirfomene
feat: allow self payment
3d9456c 
This PR solves issue lightningdevkit#2462. If we asked to
pay an invoice that we generated ourselves. We
generate PaymentSent and PaymentClaimable event
and mark the payment as fulfilled in our set
of outbound payments.

This PR is important because we realized users
can easily screw up self payments when they implement
it themselves. See here: https://lists.linuxfoundation.org/pipermail/lightning-dev/2023-June/003983.html
vladimirfomene added a commit to vladimirfomene/rust-lightning that referenced this issue Sep 22, 2023
@vladimirfomene
feat: allow self payment
6841df7 
This PR solves issue lightningdevkit#2462. If we asked to
pay an invoice that we generated ourselves. We
generate PaymentSent and PaymentClaimable event
and mark the payment as fulfilled in our set
of outbound payments.

This PR is important because we realized users
can easily screw up self payments when they implement
it themselves. See here: https://lists.linuxfoundation.org/pipermail/lightning-dev/2023-June/003983.html
vladimirfomene added a commit to vladimirfomene/rust-lightning that referenced this issue Sep 22, 2023
@vladimirfomene
feat: allow self payment
70d8f7e 
This PR solves issue lightningdevkit#2462. If we asked to
pay an invoice that we generated ourselves. We
generate PaymentSent and PaymentClaimable event
and mark the payment as fulfilled in our set
of outbound payments.

This PR is important because we realized users
can easily screw up self payments when they implement
it themselves. See here: https://lists.linuxfoundation.org/pipermail/lightning-dev/2023-June/003983.html
vladimirfomene added a commit to vladimirfomene/rust-lightning that referenced this issue Sep 22, 2023
@vladimirfomene
feat: allow self payment
59cf464 
This PR solves issue lightningdevkit#2462. If we asked to
pay an invoice that we generated ourselves. We
generate PaymentSent and PaymentClaimable event
and mark the payment as fulfilled in our set
of outbound payments.

This PR is important because we realized users
can easily screw up self payments when they implement
it themselves. See here: https://lists.linuxfoundation.org/pipermail/lightning-dev/2023-June/003983.html
vladimirfomene added a commit to vladimirfomene/rust-lightning that referenced this issue Oct 27, 2023
@vladimirfomene
feat: allow self payment
1e65c4a 
This PR solves issue lightningdevkit#2462. If we asked to
pay an invoice that we generated ourselves. We
generate PaymentSent and PaymentClaimable event
and mark the payment as fulfilled in our set
of outbound payments.

This PR is important because we realized users
can easily screw up self payments when they implement
it themselves. See here: https://lists.linuxfoundation.org/pipermail/lightning-dev/2023-June/003983.html
vladimirfomene added a commit to vladimirfomene/rust-lightning that referenced this issue Oct 28, 2023
@vladimirfomene
feat: allow self payment
fe79793 
This PR solves issue lightningdevkit#2462. If we asked to
pay an invoice that we generated ourselves. We
generate PaymentSent and PaymentClaimable event
and mark the payment as fulfilled in our set
of outbound payments.

This PR is important because we realized users
can easily screw up self payments when they implement
it themselves. See here: https://lists.linuxfoundation.org/pipermail/lightning-dev/2023-June/003983.html
vladimirfomene added a commit to vladimirfomene/rust-lightning that referenced this issue Nov 1, 2023
@vladimirfomene
feat: allow self payment
b286fbc 
This PR solves issue lightningdevkit#2462. If we asked to
pay an invoice that we generated ourselves. We
generate PaymentSent and PaymentClaimable event
and mark the payment as fulfilled in our set
of outbound payments.

This PR is important because we realized users
can easily screw up self payments when they implement
it themselves. See here: https://lists.linuxfoundation.org/pipermail/lightning-dev/2023-June/003983.html
vladimirfomene added a commit to vladimirfomene/rust-lightning that referenced this issue Nov 1, 2023
@vladimirfomene
feat: allow self payment
3d13a83 
This PR solves issue lightningdevkit#2462. If we asked to
pay an invoice that we generated ourselves. We
generate PaymentSent and PaymentClaimable event
and mark the payment as fulfilled in our set
of outbound payments.

This PR is important because we realized users
can easily screw up self payments when they implement
it themselves. See here: https://lists.linuxfoundation.org/pipermail/lightning-dev/2023-June/003983.html
vladimirfomene added a commit to vladimirfomene/rust-lightning that referenced this issue Nov 3, 2023
@vladimirfomene
feat: allow self payment
d5f4fba 
This PR solves issue lightningdevkit#2462. If we asked to
pay an invoice that we generated ourselves. We
generate PaymentSent and PaymentClaimable event
and mark the payment as fulfilled in our set
of outbound payments.

This PR is important because we realized users
can easily screw up self payments when they implement
it themselves. See here: https://lists.linuxfoundation.org/pipermail/lightning-dev/2023-June/003983.html
vladimirfomene added a commit to vladimirfomene/rust-lightning that referenced this issue Nov 12, 2023
@vladimirfomene
feat: allow self payment
b9f4043 
This PR solves issue lightningdevkit#2462. If we asked to
pay an invoice that we generated ourselves. We
generate PaymentSent and PaymentClaimable event
and mark the payment as fulfilled in our set
of outbound payments.

This PR is important because we realized users
can easily screw up self payments when they implement
it themselves. See here: https://lists.linuxfoundation.org/pipermail/lightning-dev/2023-June/003983.html
vladimirfomene added a commit to vladimirfomene/rust-lightning that referenced this issue Jan 11, 2024
@vladimirfomene
feat: allow self payment
4e5758e 
This PR solves issue lightningdevkit#2462. If we asked to
pay an invoice that we generated ourselves. We
generate PaymentSent and PaymentClaimable event
and mark the payment as fulfilled in our set
of outbound payments.

This PR is important because we realized users
can easily screw up self payments when they implement
it themselves. See here: https://lists.linuxfoundation.org/pipermail/lightning-dev/2023-June/003983.html
vladimirfomene added a commit to vladimirfomene/rust-lightning that referenced this issue Jan 26, 2024
@vladimirfomene
feat: allow self payment
b73cfd5 
This PR solves issue lightningdevkit#2462. If we asked to
pay an invoice that we generated ourselves. We
generate PaymentSent and PaymentClaimable event
and mark the payment as fulfilled in our set
of outbound payments.

This PR is important because we realized users
can easily screw up self payments when they implement
it themselves. See here: https://lists.linuxfoundation.org/pipermail/lightning-dev/2023-June/003983.html
vladimirfomene added a commit to vladimirfomene/rust-lightning that referenced this issue Jan 29, 2024
@vladimirfomene
feat: allow self payment
1a5be82 
This PR solves issue lightningdevkit#2462. If we asked to
pay an invoice that we generated ourselves. We
generate PaymentSent and PaymentClaimable event
and mark the payment as fulfilled in our set
of outbound payments.

This PR is important because we realized users
can easily screw up self payments when they implement
it themselves. See here: https://lists.linuxfoundation.org/pipermail/lightning-dev/2023-June/003983.html
vladimirfomene added a commit to vladimirfomene/rust-lightning that referenced this issue Feb 5, 2024
@vladimirfomene
feat: allow self payment
6de92ed 
This PR solves issue lightningdevkit#2462. If we asked to
pay an invoice that we generated ourselves. We
generate PaymentSent and PaymentClaimable event
and mark the payment as fulfilled in our set
of outbound payments.

This PR is important because we realized users
can easily screw up self payments when they implement
it themselves. See here: https://lists.linuxfoundation.org/pipermail/lightning-dev/2023-June/003983.html
vladimirfomene added a commit to vladimirfomene/rust-lightning that referenced this issue Feb 5, 2024
@vladimirfomene
feat: allow self payment
e280f9f 
This PR solves issue lightningdevkit#2462. If we asked to
pay an invoice that we generated ourselves. We
generate PaymentSent and PaymentClaimable event
and mark the payment as fulfilled in our set
of outbound payments.

This PR is important because we realized users
can easily screw up self payments when they implement
it themselves. See here: https://lists.linuxfoundation.org/pipermail/lightning-dev/2023-June/003983.html
vladimirfomene added a commit to vladimirfomene/rust-lightning that referenced this issue Mar 8, 2024
@vladimirfomene
feat: allow self payment
a4e66de 
This PR solves issue lightningdevkit#2462. If we asked to
pay an invoice that we generated ourselves. We
generate PaymentSent and PaymentClaimable event
and mark the payment as fulfilled in our set
of outbound payments.

This PR is important because we realized users
can easily screw up self payments when they implement
it themselves. See here: https://lists.linuxfoundation.org/pipermail/lightning-dev/2023-June/003983.html
vladimirfomene added a commit to vladimirfomene/rust-lightning that referenced this issue Mar 11, 2024
@vladimirfomene
feat: allow self payment
bdab670 
This PR solves issue lightningdevkit#2462. If we asked to
pay an invoice that we generated ourselves. We
generate PaymentSent and PaymentClaimable event
and mark the payment as fulfilled in our set
of outbound payments.

This PR is important because we realized users
can easily screw up self payments when they implement
it themselves. See here: https://lists.linuxfoundation.org/pipermail/lightning-dev/2023-June/003983.html
vladimirfomene added a commit to vladimirfomene/rust-lightning that referenced this issue Mar 11, 2024
@vladimirfomene
feat: allow self payment
ef070b8 
This PR solves issue lightningdevkit#2462. If we asked to
pay an invoice that we generated ourselves. We
generate PaymentSent and PaymentClaimable event
and mark the payment as fulfilled in our set
of outbound payments.

This PR is important because we realized users
can easily screw up self payments when they implement
it themselves. See here: https://lists.linuxfoundation.org/pipermail/lightning-dev/2023-June/003983.html
vladimirfomene added a commit to vladimirfomene/rust-lightning that referenced this issue Mar 11, 2024
@vladimirfomene
feat: allow self payment
853f63b 
This PR solves issue lightningdevkit#2462. If we asked to
pay an invoice that we generated ourselves. We
generate PaymentSent and PaymentClaimable event
and mark the payment as fulfilled in our set
of outbound payments.

This PR is important because we realized users
can easily screw up self payments when they implement
it themselves. See here: https://lists.linuxfoundation.org/pipermail/lightning-dev/2023-June/003983.html
vladimirfomene added a commit to vladimirfomene/rust-lightning that referenced this issue Mar 11, 2024
@vladimirfomene
feat: allow self payment
10bd39b 
This PR solves issue lightningdevkit#2462. If we asked to
pay an invoice that we generated ourselves. We
generate PaymentSent and PaymentClaimable event
and mark the payment as fulfilled in our set
of outbound payments.

This PR is important because we realized users
can easily screw up self payments when they implement
it themselves. See here: https://lists.linuxfoundation.org/pipermail/lightning-dev/2023-June/003983.html
This was referenced Jun 17, 2024
Merged
Closed
@TheBlueMatt TheBlueMatt modified the milestones: 0.1.1, 0.1 Jun 23, 2024
@TheBlueMatt TheBlueMatt modified the milestones: 0.1, 0.1.1 Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
2 participants
@TheBlueMatt @vladimirfomene