Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle pay-to-self payments #2363

Closed
TheBlueMatt opened this issue Jun 19, 2023 · 1 comment
Closed

Handle pay-to-self payments #2363

TheBlueMatt opened this issue Jun 19, 2023 · 1 comment
Milestone

Comments

@TheBlueMatt
Copy link
Collaborator

For custodial multi-user walles, seeing an invoice that pays to self should generally be handled as if it were a "real" payment" - generate payment sent/received events like normal. We were generally relying on users to implement this themselves (as its kinda strange for a non-custodial wallet to do this), but it turns out its easy to screw up. Specifically, LNBits screwed up their pay-to-self payments [1] and allowed underpayment, and its largely the "obvious" way to implement it, so I wouldn't be surprised if some of our users screwed it up eventually too. Worth considering handling it for users (maybe with a config option).

[1] https://lists.linuxfoundation.org/pipermail/lightning-dev/2023-June/003983.html

@TheBlueMatt TheBlueMatt added this to the 0.2 milestone Jun 19, 2023
@wpaulino
Copy link
Contributor

Duplicate of #2462

@wpaulino wpaulino marked this as a duplicate of #2462 Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants