Add expiry to phantom invoice utility functions #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. So I assumed we don't need to pass in a payment secret anymore. If this is wrong then I can fix up. |
Codecov Report
@@ Coverage Diff @@
## main #1422 +/- ##
==========================================
+ Coverage 90.84% 90.85% +0.01%
==========================================
Files 74 74
Lines 41288 41361 +73
Branches 41288 41361 +73
==========================================
+ Hits 37507 37580 +73
Misses 3781 3781
Continue to review full report at Codecov.
|
TheBlueMatt
reviewed
Apr 15, 2022
lightning-invoice/src/utils.rs
Outdated
| amt_msat: Option<u64>, description_hash: Sha256, payment_hash: PaymentHash, | ||
| payment_secret: PaymentSecret, phantom_route_hints: Vec<PhantomRouteHints>, | ||
| keys_manager: K, network: Currency, | ||
| amt_msat: Option<u64>, payment_hash: Option<PaymentHash>, invoice_expiry_delta_secs: u32, description_hash: Sha256, phantom_route_hints: Vec<PhantomRouteHints>, keys_manager: K, network: Currency, |
There was a problem hiding this comment.
Lets break the line at least a bit so its not so long :). Try to break around 100 chars.
TheBlueMatt
reviewed
Apr 15, 2022
TheBlueMatt
reviewed
Apr 15, 2022
Ah, just wanted to check on something. Thought I had made some mistake in my conceptual understand. Will promote it out of draft now :) |
dunxen
force-pushed
the
2022-04-invoice-expiry
branch
from
bf41004 to
2d954c4
Compare
dunxen
force-pushed
the
2022-04-invoice-expiry
branch
from
2d954c4 to
b741ca5
Compare
TheBlueMatt
reviewed
Apr 15, 2022
dunxen
force-pushed
the
2022-04-invoice-expiry
branch
from
b741ca5 to
3170ac9
Compare
dunxen
force-pushed
the
2022-04-invoice-expiry
branch
from
3170ac9 to
8f047ca
Compare
TheBlueMatt
approved these changes
Apr 16, 2022
valentinewallace
approved these changes
Apr 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1411