Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable automatic formatting #1774

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

futurepaul
Copy link
Contributor

I'd love it if this project adopted rustfmt but in the meantime I think it's a nicer first experience to not accidentally have my editor format the code on save (default behavior, at least on vs code + rust analyzer) and then I need to remember to disable rustfmt for this specific project. Rustfmt has a flag for this: https://rust-lang.github.io/rustfmt/?version=v1.5.1&search=#disable_all_formatting.

There's also an "ignore" flag but that didn't work when I tried it.

related to #410

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2022

Codecov Report

Base: 90.79% // Head: 90.80% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (e24afa7) compared to base (6772609).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1774      +/-   ##
==========================================
+ Coverage   90.79%   90.80%   +0.01%     
==========================================
  Files          87       87              
  Lines       46969    46969              
  Branches    46969    46969              
==========================================
+ Hits        42646    42651       +5     
+ Misses       4323     4318       -5     
Impacted Files Coverage Δ
lightning/src/ln/peer_channel_encryptor.rs 93.38% <0.00%> (-0.25%) ⬇️
lightning/src/chain/channelmonitor.rs 91.16% <0.00%> (-0.06%) ⬇️
lightning/src/ln/functional_tests.rs 97.08% <0.00%> (+0.07%) ⬆️
lightning/src/ln/monitor_tests.rs 99.55% <0.00%> (+0.11%) ⬆️
lightning/src/chain/onchaintx.rs 95.63% <0.00%> (+0.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@dunxen dunxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's indeed annoying when using format-on-save and such.

@TheBlueMatt TheBlueMatt merged commit 1caf1ab into lightningdevkit:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants