-
Notifications
You must be signed in to change notification settings - Fork 940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to JDK 13 for releasing and CI build. #2424
Conversation
2e0cb90
to
6165e6a
Compare
Codecov Report
@@ Coverage Diff @@
## master #2424 +/- ##
============================================
- Coverage 72.99% 72.96% -0.03%
+ Complexity 10753 10749 -4
============================================
Files 946 946
Lines 41804 41804
Branches 5206 5206
============================================
- Hits 30515 30503 -12
- Misses 8627 8639 +12
Partials 2662 2662
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @anuraaga
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! @anuraaga
I've been releasing on Linux. No idea it worked so far. 🙈 |
Also adds JRE exact version to paths so version can be updated without manually clearing CI cache I found that JDK12 has this bug when generating javadoc https://bugs.openjdk.java.net/browse/JDK-8222091 I sort of wonder how we've been releasing so far (do we release on Windows?), but I guess it's a good time to switch to JDK13 for release.
Also adds JRE exact version to paths so version can be updated without manually clearing CI cache
I found that JDK12 has this bug when generating javadoc
https://bugs.openjdk.java.net/browse/JDK-8222091
I sort of wonder how we've been releasing so far (do we release on Windows?), but I guess it's a good time to switch to JDK13 for release.