Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to JDK 13 for releasing and CI build. #2424

Merged
merged 3 commits into from
Jan 30, 2020

Conversation

anuraaga
Copy link
Collaborator

@anuraaga anuraaga commented Jan 29, 2020

Also adds JRE exact version to paths so version can be updated without manually clearing CI cache

I found that JDK12 has this bug when generating javadoc

https://bugs.openjdk.java.net/browse/JDK-8222091

I sort of wonder how we've been releasing so far (do we release on Windows?), but I guess it's a good time to switch to JDK13 for release.

@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #2424 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2424      +/-   ##
============================================
- Coverage     72.99%   72.96%   -0.03%     
+ Complexity    10753    10749       -4     
============================================
  Files           946      946              
  Lines         41804    41804              
  Branches       5206     5206              
============================================
- Hits          30515    30503      -12     
- Misses         8627     8639      +12     
  Partials       2662     2662
Impacted Files Coverage Δ Complexity Δ
.../linecorp/armeria/internal/Http2GoAwayHandler.java 57.5% <0%> (-2.5%) 14% <0%> (-1%)
...a/com/linecorp/armeria/client/HttpChannelPool.java 76.22% <0%> (-2.46%) 57% <0%> (-2%)
...om/linecorp/armeria/client/HttpSessionHandler.java 59.84% <0%> (-2.37%) 28% <0%> (-2%)
...rp/armeria/common/stream/DefaultStreamMessage.java 90.71% <0%> (-1.43%) 54% <0%> (-1%)
.../main/java/com/linecorp/armeria/server/Server.java 81% <0%> (-1.17%) 28% <0%> (ø)
...inecorp/armeria/server/HttpResponseSubscriber.java 85.53% <0%> (+1.27%) 72% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b32b8e...d9bb877. Read the comment docs.

Copy link
Member

@trustin trustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @anuraaga

@trustin trustin added this to the 0.98.0 milestone Jan 30, 2020
Copy link
Contributor

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @anuraaga

@trustin trustin merged commit eefaf60 into line:master Jan 30, 2020
@trustin
Copy link
Member

trustin commented Jan 30, 2020

I sort of wonder how we've been releasing so far (do we release on Windows?)

I've been releasing on Linux. No idea it worked so far. 🙈

fmguerreiro pushed a commit to fmguerreiro/armeria that referenced this pull request Sep 19, 2020
Also adds JRE exact version to paths so version can be updated without manually clearing CI cache

I found that JDK12 has this bug when generating javadoc

https://bugs.openjdk.java.net/browse/JDK-8222091

I sort of wonder how we've been releasing so far (do we release on Windows?), but I guess it's a good time to switch to JDK13 for release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants