add missing canonicalize for util::resolve_binary #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ma2bd
force-pushed
the
fix_linera_net_up
branch
from
983ef6d to
39f595d
Compare
ma2bd
force-pushed
the
fix_linera_net_up
branch
from
39f595d to
966de47
Compare
afck
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix
cargo build --bins && target/debug/linera net upafter #1107Proposal
Make
util::resolve_binaryreturn an absolute path.The issue occurs when the current binary is a relative path. Before #1107,
cargo_force_build_binarywas calling.canonicalize().Test Plan
CI
The new integration test covers this use case: