chore(transport): Use socket2 to obtain orig_dst #3626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
zaharidichev
changed the title
olix0r
approved these changes
Feb 19, 2025
alpeb
added a commit
that referenced
this pull request
Mar 20, 2025
In #3626, we refactored the origin_dst determination logic to utilize socket2 calls. However, this change inadvertently disrupted IPv6 and dual-stack support, causing the server to fail to start when deployed on such network configurations: ``` WARN ThreadId(01) inbound: linkerd_app_core::serve: Server failed to accept connection error=No such file or directory (os error 2) ``` This change reintroduces detection of the current network family, calling socket2's `original_dst()` or `original_dst_ipv6()` depending on the case. Tested fine in both IPv6 and dual-stack Kind clusters.
olix0r
pushed a commit
that referenced
this pull request
Mar 21, 2025
In #3626, we refactored the origin_dst determination logic to utilize socket2 calls. However, this change inadvertently disrupted IPv6 and dual-stack support, causing the server to fail to start when deployed on such network configurations: ``` WARN ThreadId(01) inbound: linkerd_app_core::serve: Server failed to accept connection error=No such file or directory (os error 2) ``` This change reintroduces detection of the current network family, calling socket2's `original_dst()` or `original_dst_ipv6()` depending on the case. Tested fine in both IPv6 and dual-stack Kind clusters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code that we currently use to obtain
orig_dsthas been borrowed fromnet2-rs.Since we already have socket2 in our dependency tree, we can simplify the logic by
just using socket2. An added benefit of that is that socket2 provides support for
obtaining
orig_dston Windows.Signed-off-by: Zahari Dichev zaharidichev@gmail.com