New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app: inbound: add fuzzer #977

Merged

hawkw merged 5 commits into linkerd:main from DavidKorczynski:main

Apr 15, 2021

Contributor

DavidKorczynski commented Apr 12, 2021 •

edited

Loading

The focus of this PR is adding a n end-to-end style fuzzer.

Notice I had to disable denying of warnings in two places in order to compile this.

The fuzzer is largely inspired by unmeshed_http1_hello_world

linkerd2-proxy/linkerd/app/inbound/src/http/tests.rs

Line 49 in 863ef23

async fn unmeshed_http1_hello_world() {

DavidKorczynski added 2 commits

April 12, 2021 21:24


          app: inbound: adds fuzzer.

ae4d259

Signed-off-by: davkor <david@adalogics.com>


          disable warnings in order to compile with nightly.

Signed-off-by: davkor <david@adalogics.com>

DavidKorczynski requested a review from a team

April 12, 2021 20:29


          app: inbound: fuzzer: fix toml to pass check.

28c2425

Signed-off-by: davkor <david@adalogics.com>

olix0r reviewed

View reviewed changes

linkerd/app/core/src/lib.rs Outdated Show resolved Hide resolved

linkerd/app/inbound/fuzz/fuzz_targets/fuzz_target_1.rs Outdated Show resolved Hide resolved

linkerd/app/inbound/fuzz/fuzz_targets/fuzz_target_1.rs Outdated Show resolved Hide resolved

linkerd/app/test/src/lib.rs Outdated Show resolved Hide resolved

linkerd/app/inbound/src/http/mod.rs Outdated Show resolved Hide resolved

linkerd/app/inbound/src/http/mod.rs Outdated Show resolved Hide resolved

linkerd/app/inbound/src/http/mod.rs Outdated Show resolved Hide resolved

linkerd/app/inbound/src/http/mod.rs Outdated Show resolved Hide resolved

linkerd/app/inbound/fuzz/fuzz_targets/fuzz_target_1.rs Outdated Show resolved Hide resolved

olix0r requested a review from hawkw

April 13, 2021 00:01


          app: inbound: fuzzers: cleanup and generalise fuzzer.

83e9f50

Signed-off-by: davkor <david@adalogics.com>

hawkw reviewed

View reviewed changes

linkerd/app/inbound/fuzz/fuzz_targets/fuzz_target_1.rs Outdated Show resolved Hide resolved

linkerd/app/inbound/fuzz/fuzz_targets/fuzz_target_1.rs Outdated Show resolved Hide resolved

linkerd/app/inbound/src/http/mod.rs Show resolved Hide resolved

linkerd/app/inbound/src/http/mod.rs Outdated Show resolved Hide resolved

linkerd/app/inbound/fuzz/fuzz_targets/fuzz_target_1.rs Outdated Show resolved Hide resolved


          app: inbound: fuzzers: cleanup.

e666134

Signed-off-by: davkor <david@adalogics.com>

olix0r approved these changes

View reviewed changes

hawkw approved these changes

View reviewed changes

Contributor

hawkw left a comment

This looks like a good start to me!

I'd love to see fuzzing for more variables in the future --- it would be nice to be able to produce more potentially-malicious requests. But, we can always keep adding more fuzzers, and this looks like a great start!

linkerd/app/inbound/fuzz/fuzz_targets/fuzz_target_1.rs

+              fuzz_target!(|inp: TransportHeaderSpec| {
+                  if let Ok(uri) = std::str::from_utf8(&inp.uri[..]) {
+                      if let Ok(header_name) = std::str::from_utf8(&inp.header_name[..]) {
+                          if let Ok(header_value) = std::str::from_utf8(&inp.header_value[..]) {

Contributor

hawkw Apr 15, 2021

should we also be testing behavior with header values that are not valid UTF-8? we can always add this in a follow-up.

Contributor Author

DavidKorczynski commented Apr 15, 2021

This looks like a good start to me!

I'd love to see fuzzing for more variables in the future --- it would be nice to be able to produce more potentially-malicious requests. But, we can always keep adding more fuzzers, and this looks like a great start!

Great stuff! I agree, and I will get this up in the near future. It would be nice to do it a bit incrementally though so we can see how things work when clusterfuzz starts putting a lot of compute power on it.

hawkw merged commit 3a3f25f into linkerd:main

DavidKorczynski mentioned this pull request

clean up linkerd2 build. google/oss-fuzz#5647

Merged

olix0r added a commit to linkerd/linkerd2 that referenced this pull request


          proxy: v2.142.0

c52d07f

This release primarily improves protocol detection error messages in the
admin server so that logs clearly indicate when the client expected a
different TLS server identity than that of the running proxy.

A number of internal improvements have been made, especially eliminating
some potential runtime panics detected by oss-fuzz. It is not expected
that these panics could be triggered in typical cluster configurations.

---

* discover: replace `linkerd-channel` with `tokio-util` `PollSender` (linkerd/linkerd2-proxy#969)
* replace `linkerd-channel` with `tokio-stream` (linkerd/linkerd2-proxy#970)
* concurrency-limit: use `tokio-util`'s `PollSemaphore` (linkerd/linkerd2-proxy#968)
* http: Do not fail fuzz tests when all IO is not read (linkerd/linkerd2-proxy#973)
* transport: Fix orig-dst compilation on non-Linux targets  (linkerd/linkerd2-proxy#974)
* Update trust-dns to fix possible panic (linkerd/linkerd2-proxy#975)
*  addr: fix `to_http_authority` panic with IPv6 (linkerd/linkerd2-proxy#976)
* outbound: skip logical stacks when no profile is discovered (linkerd/linkerd2-proxy#963)
* split: change traffic splits to require a profile (linkerd/linkerd2-proxy#964)
* inbound: only build profile route stacks when a profile is resolved (linkerd/linkerd2-proxy#966)
* profiles: make receiver param in `route_request` non-optional (linkerd/linkerd2-proxy#967)
* outbound: move target types into stack modules (linkerd/linkerd2-proxy#971)
* outbound: only build logical stacks for profiles with logical addrs (linkerd/linkerd2-proxy#972)
* app: inbound: add fuzzer (linkerd/linkerd2-proxy#977)
* admin: Fail connections when HTTP detection fails (linkerd/linkerd2-proxy#979)
* reduce error boilerplate with `thiserror` (linkerd/linkerd2-proxy#980)
* app: inbound: fuzzer: generalise fuzzers and solve coverage build (linkerd/linkerd2-proxy#978)
* admin: Assume meshed connections are HTTP/2 (linkerd/linkerd2-proxy#982)
* chore: Fix deprecations on nightly (linkerd/linkerd2-proxy#983)

olix0r mentioned this pull request

proxy: v2.142.0 linkerd/linkerd2#6047

Closed

olix0r added a commit to linkerd/linkerd2 that referenced this pull request


          proxy: v2.143.0

0d6eada

This release simplifies internals so that endpoint-forwarding logic is
completely distinct from handling of load balanced services.

The ingress-mode outbound proxy has been simplified to *require* the
`l5d-dst-override` header and to fail non-HTTP communication. This
ensures that the ingress-mode proxy does not unexpectedly revert to
insecure communication.

Finally, a regression was recently introduced that caused all proxy logs
to be output with ANSI control characters. Logs are now output in
plaintext by default

---

* discover: replace `linkerd-channel` with `tokio-util` `PollSender` (linkerd/linkerd2-proxy#969)
* replace `linkerd-channel` with `tokio-stream` (linkerd/linkerd2-proxy#970)
* concurrency-limit: use `tokio-util`'s `PollSemaphore` (linkerd/linkerd2-proxy#968)
* http: Do not fail fuzz tests when all IO is not read (linkerd/linkerd2-proxy#973)
* transport: Fix orig-dst compilation on non-Linux targets  (linkerd/linkerd2-proxy#974)
* Update trust-dns to fix possible panic (linkerd/linkerd2-proxy#975)
*  addr: fix `to_http_authority` panic with IPv6 (linkerd/linkerd2-proxy#976)
* outbound: skip logical stacks when no profile is discovered (linkerd/linkerd2-proxy#963)
* split: change traffic splits to require a profile (linkerd/linkerd2-proxy#964)
* inbound: only build profile route stacks when a profile is resolved (linkerd/linkerd2-proxy#966)
* profiles: make receiver param in `route_request` non-optional (linkerd/linkerd2-proxy#967)
* outbound: move target types into stack modules (linkerd/linkerd2-proxy#971)
* outbound: only build logical stacks for profiles with logical addrs (linkerd/linkerd2-proxy#972)
* app: inbound: add fuzzer (linkerd/linkerd2-proxy#977)
* admin: Fail connections when HTTP detection fails (linkerd/linkerd2-proxy#979)
* reduce error boilerplate with `thiserror` (linkerd/linkerd2-proxy#980)
* app: inbound: fuzzer: generalise fuzzers and solve coverage build (linkerd/linkerd2-proxy#978)
* admin: Assume meshed connections are HTTP/2 (linkerd/linkerd2-proxy#982)
* chore: Fix deprecations on nightly (linkerd/linkerd2-proxy#983)
* fuzz: Add logging to fuzz targets (linkerd/linkerd2-proxy#985)
* fuzz: don't panic when the proxy closes the conn (linkerd/linkerd2-proxy#986)
* Commit lock files for fuzzers (linkerd/linkerd2-proxy#984)
* fuzz: allow client requests to fail  (linkerd/linkerd2-proxy#989)
* tower: update dependency to 0.4.7 (linkerd/linkerd2-proxy#990)
* outbound: Make the Endpoint::logical_addr field optional (linkerd/linkerd2-proxy#991)
* trace: explicitly disable ANSI terminal colors (linkerd/linkerd2-proxy#994)
* ingress: Require the l5d-dst-override header (linkerd/linkerd2-proxy#992)
* outbound: Do not support TCP-forwarding in ingress-mode (linkerd/linkerd2-proxy#995)
* Decouple tcp forward stack from Endpoint target (linkerd/linkerd2-proxy#996)
* Pickup linkerd-await wrapper in docker build (linkerd/linkerd2-proxy#999)
* docs: Add fuzzing report (linkerd/linkerd2-proxy#1000)
* tests: Use io::Error in mocked connector (linkerd/linkerd2-proxy#1001)
* outbound: Decouple endpoint & logical stacks (linkerd/linkerd2-proxy#1002)

olix0r mentioned this pull request

proxy: v2.143.0 linkerd/linkerd2#6107

Merged

olix0r added a commit to linkerd/linkerd2 that referenced this pull request


          proxy: v2.143.0 (#6107)

847b744

This release simplifies internals so that endpoint-forwarding logic is
completely distinct from handling of load balanced services.

The ingress-mode outbound proxy has been simplified to *require* the
`l5d-dst-override` header and to fail non-HTTP communication. This
ensures that the ingress-mode proxy does not unexpectedly revert to
insecure communication.

Finally, a regression was recently introduced that caused all proxy logs
to be output with ANSI control characters. Logs are now output in
plaintext by default

---

* discover: replace `linkerd-channel` with `tokio-util` `PollSender` (linkerd/linkerd2-proxy#969)
* replace `linkerd-channel` with `tokio-stream` (linkerd/linkerd2-proxy#970)
* concurrency-limit: use `tokio-util`'s `PollSemaphore` (linkerd/linkerd2-proxy#968)
* http: Do not fail fuzz tests when all IO is not read (linkerd/linkerd2-proxy#973)
* transport: Fix orig-dst compilation on non-Linux targets  (linkerd/linkerd2-proxy#974)
* Update trust-dns to fix possible panic (linkerd/linkerd2-proxy#975)
*  addr: fix `to_http_authority` panic with IPv6 (linkerd/linkerd2-proxy#976)
* outbound: skip logical stacks when no profile is discovered (linkerd/linkerd2-proxy#963)
* split: change traffic splits to require a profile (linkerd/linkerd2-proxy#964)
* inbound: only build profile route stacks when a profile is resolved (linkerd/linkerd2-proxy#966)
* profiles: make receiver param in `route_request` non-optional (linkerd/linkerd2-proxy#967)
* outbound: move target types into stack modules (linkerd/linkerd2-proxy#971)
* outbound: only build logical stacks for profiles with logical addrs (linkerd/linkerd2-proxy#972)
* app: inbound: add fuzzer (linkerd/linkerd2-proxy#977)
* admin: Fail connections when HTTP detection fails (linkerd/linkerd2-proxy#979)
* reduce error boilerplate with `thiserror` (linkerd/linkerd2-proxy#980)
* app: inbound: fuzzer: generalise fuzzers and solve coverage build (linkerd/linkerd2-proxy#978)
* admin: Assume meshed connections are HTTP/2 (linkerd/linkerd2-proxy#982)
* chore: Fix deprecations on nightly (linkerd/linkerd2-proxy#983)
* fuzz: Add logging to fuzz targets (linkerd/linkerd2-proxy#985)
* fuzz: don't panic when the proxy closes the conn (linkerd/linkerd2-proxy#986)
* Commit lock files for fuzzers (linkerd/linkerd2-proxy#984)
* fuzz: allow client requests to fail  (linkerd/linkerd2-proxy#989)
* tower: update dependency to 0.4.7 (linkerd/linkerd2-proxy#990)
* outbound: Make the Endpoint::logical_addr field optional (linkerd/linkerd2-proxy#991)
* trace: explicitly disable ANSI terminal colors (linkerd/linkerd2-proxy#994)
* ingress: Require the l5d-dst-override header (linkerd/linkerd2-proxy#992)
* outbound: Do not support TCP-forwarding in ingress-mode (linkerd/linkerd2-proxy#995)
* Decouple tcp forward stack from Endpoint target (linkerd/linkerd2-proxy#996)
* Pickup linkerd-await wrapper in docker build (linkerd/linkerd2-proxy#999)
* docs: Add fuzzing report (linkerd/linkerd2-proxy#1000)
* tests: Use io::Error in mocked connector (linkerd/linkerd2-proxy#1001)
* outbound: Decouple endpoint & logical stacks (linkerd/linkerd2-proxy#1002)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet