Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit support and fix pre-commit check error #32

Merged
merged 7 commits into from
Oct 12, 2019
Merged

Conversation

linw1995
Copy link
Owner

@linw1995 linw1995 added enhancement New feature or request travis-ci docs labels Oct 12, 2019
@linw1995 linw1995 self-assigned this Oct 12, 2019
@codecov
Copy link

codecov bot commented Oct 12, 2019

Codecov Report

Merging #32 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #32   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines         221    220    -1     
  Branches       31     31           
=====================================
- Hits          221    220    -1
Impacted Files Coverage Δ
data_extractor/item.py 100% <ø> (ø) ⬆️
data_extractor/lxml.py 100% <ø> (ø) ⬆️
data_extractor/exceptions.py 100% <ø> (ø) ⬆️
data_extractor/abc.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd680c1...3bf1197. Read the comment docs.

@linw1995 linw1995 merged commit d180992 into master Oct 12, 2019
@linw1995 linw1995 deleted the precommit branch October 12, 2019 17:44
linw1995 added a commit that referenced this pull request Oct 12, 2019
- d180992 Add pre-commit support and fix pre-commit check error (#32)
- bd680c1 Update pyproject.toml
- 64f30f7 remove unhappened condtional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs enhancement New feature or request travis-ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant