Introduce Fly.io runtime #2708
Merged
Introduce Fly.io runtime #2708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatanklosko
commented
Jul 12, 2024
Comment on lines
+249
to
+250
| # TODO: do not rely on private APIs. Also, ideally we should still | ||
| # be able to use Req.Test.expect/2 |
|
Uffizzi Preview |
|
Note that this relies on Docker images, so if you want to try this PR locally, change this line: livebook/lib/livebook/runtime/fly.ex Line 163 in 2fe9be2 to image = "jonatanklosko/livebook-main:main" |
josevalim
reviewed
Jul 13, 2024
josevalim
reviewed
Jul 13, 2024
josevalim
reviewed
Jul 13, 2024
Comment on lines
+12
to
+18
| node = :"#{node_base}@#{machine_id}.vm.#{app}.internal" | ||
|
|
||
| # We persist the information before the node is reachable | ||
| :persistent_term.put(:livebook_runtime_info, %{ | ||
| pid: self(), | ||
| elixir_version: System.version() | ||
| }) |
There was a problem hiding this comment.
If you want, you could move this to the runtime itself? And then you put the runtime module inside LIVEBOOK_RUNTIME env var and call it here? Then this whole code becomes generic?
There was a problem hiding this comment.
Btw, we should talk about the initialization flow. :)
josevalim
approved these changes
Jul 13, 2024
josevalim
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new runtime "Fly.io machine". In the runtime configuration UI, we ask the user for API token, which can be generated in the Fly dashboard. We create a new app (if needed) and the user can configure resources and storage. When connecting to the runtime, we create a new machine, which is automatically destroyed once the runtime is disconnected.
Changes
There are a few elements to this PR:
Now that connecting is a longer operation, I made
Runtime.connectasync. Following this, there were a lot of changes aroundLivebook.Session.Datato account for the new "connecting" state during operations, and a fair amount of tests that needed adjusting. On a sidenote, this shifted some logic fromSessionand even the LV directly toData, which is more consistent with other operations and easier to test.For the Fly runtime, we need a custom EPMD module, so I removed EPMD-less mode and now we always use the custom EPMD module. In Docker, Desktop and Escript we set the VM args automatically, however when running from source or in dev it is necessary to set
ELIXIR_ERL_OPTIONS. I plan a patch to OTP, such that we can set it after boot in the future.The Fly runtime. The runtime is implemented in
Livebook.Runtime.Flyand there much more details in the module docs. The UI flow is handled inFlyRuntimeComponentandFlyAPI.Demo
flyrt.mp4