Suggest setup without cache on dependencies error #2716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uffizzi Preview |
josevalim
reviewed
Jul 19, 2024
| @@ -189,6 +189,9 @@ defmodule Livebook.Runtime.Evaluator.Formatter do | |||
| defp error_context(error) when is_struct(error, Kino.FS.ForbiddenError), | |||
| do: {:file_entry_forbidden, error.name} | |||
|
|
|||
| defp error_context(error) when is_struct(error, Mix.Error), | |||
There was a problem hiding this comment.
Mix.Error can happen for several other reasons. Should we check the message as well?
There was a problem hiding this comment.
Which ones do you suggest? We only show the special action in the setup cell, so I would be fine with not matching the message. Your call!
There was a problem hiding this comment.
ok, lets give this a try as is then!
josevalim
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2715.
@josevalim the suggestion is a just hint and I think it's fine to show it even if already setting up without cache. I would rather avoid passing so specific information down to the outputs, but if you have a strong preference, we can :)