-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Listen on 127.0.0.1 rather than 0.0.0.0 #35
Comments
Ah I see by digging into the code that this is actually possible to override:
I didn't expected that to work because the flag is named |
@alecthomas not yet a contributor (though I plan to once my other projects calm down just a bit) but how do y’all feel about removing the need to pass in a |
IMO it's fine to bind development servers to 127.0.0.1 by default. As long as there's a way to change it, there's no real downside. |
I don’t either, but was unaware of the team’s view and wanted to toss out an option for if defaulting to 127.0.0.1 was shot down. Thanks!! |
I agree we should default to 127.0.0.1. But I think while building for production it should default to 0.0.0.0. I am not sure if bud is aware of dev/prod environments though. I guess passing the IP seems easiest solution for now. I don't like the fact that |
Is there a reason that there’s not separate functionality for changing the binding address and port separately with |
PR up to change the default to I've created a discussion for changing |
🙏 |
FYI. This is available in v0.1.1. To upgrade, run: curl -sf curl https://raw.githubusercontent.com/livebud/bud/main/install.sh | sh |
OSX throws up a security prompt every time bud starts because it's binding to 0.0.0.0. Binding to 127.0.0.1 instead will rectify this.
The text was updated successfully, but these errors were encountered: