-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: Begin accepting auth header and have it override callback URL values #2357
Conversation
3b2cfb3
to
177ce6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
return true | ||
} | ||
|
||
profilesA, err := json.Marshal(a.Profiles) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: is it ok to suppress error here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I can't see any actual situation where this wouldn't marshal but probably good practice to do something with the error anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What does this pull request do? Explain your changes. (required)
Livepeer-Transcode-Configuration
header in the HTTP Push segment endpoint.Specific updates (required)
How did you test each of these updates (required)
✅ Wrote new unit tests
✅ TODO: Manual testing
Does this pull request close any open issues?
Checklist:
make
runs successfully./test.sh
pass