fix(ai): improve AI selection algorithm #3030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickstaa
force-pushed
the
ai-video_fix-selection-algo
branch
from
640fd85 to
a69500c
Compare
This commit modifies the selection algorithm to continue retrying for a duration of one second instead of stopping after four attempts. This change addresses issues encountered with the current algorithm's performance in environments with 15 nodes on the network, ensuring more robust and reliable operation until further optimizations can be implemented.
rickstaa
force-pushed
the
ai-video_fix-selection-algo
branch
from
a69500c to
5a08c6d
Compare
This commit replaces the time-based for-loop in the selection algorithm's retry logic with a more context-aware approach.
rickstaa
force-pushed
the
ai-video_fix-selection-algo
branch
from
87d8213 to
a3007cf
Compare
|
Here's @yondonfu; this straightforward solution might help ease the situation. I have several other PRs lined up to fix the double selection, but this one is ready for merging if there are no objections. I also am finishing a tech spec explaining all the improvements that can be made. The only downside I see is the increased cost because we pay orch's for returning an |
eliteprox
approved these changes
May 1, 2024
yondonfu
reviewed
May 2, 2024
5 tasks
This was referenced May 15, 2024
Merged
5 tasks
This was referenced Jul 1, 2024
Merged
This was referenced Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This pull request modifies the selection algorithm to continue retrying for a duration of one second instead of stopping after four attempts. This change addresses issues encountered with the current algorithm's performance in environments with 15 nodes on the network, ensuring more robust and reliable operation until further optimizations can be implemented.
Specific updates (required)
How did you test each of these updates (required)
I tested it offchain/onchain on my development Gateway.
Does this pull request close any open issues?
Checklist:
makeruns successfully./test.shpass