Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add image-to-text pipeline to remote worker #3229

Conversation

ad-astra-video
Copy link
Collaborator

What does this pull request do? Explain your changes. (required)
Adds remote worker parts to server package so image-to-text pipeline can be processed by remote working.

Specific updates (required)

  • add image to text to runAIJob
  • update to add pipeline to parseMultipartResult
  • Add test in server/ai_worker_test.go

How did you test each of these updates (required)

Ran tests and built docker container to test combined and split Orchestrator and AI Worker

Does this pull request close any open issues?

No

Checklist:

@ad-astra-video ad-astra-video requested a review from mjh1 November 1, 2024 20:33
@github-actions github-actions bot added the AI Issues and PR related to the AI-video branch. label Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 35.75149%. Comparing base (bf10079) to head (4cf7d0d).
Report is 2 commits behind head on ai-video.

Files with missing lines Patch % Lines
server/ai_worker.go 73.33333% 2 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##            ai-video       #3229         +/-   ##
===================================================
+ Coverage   35.73535%   35.75149%   +0.01614%     
===================================================
  Files            124         124                 
  Lines          34929       34944         +15     
===================================================
+ Hits           12482       12493         +11     
- Misses         21754       21756          +2     
- Partials         693         695          +2     
Files with missing lines Coverage Δ
server/ai_http.go 10.00000% <100.00000%> (ø)
server/ai_worker.go 49.89059% <73.33333%> (+0.79557%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4a5ef1...4cf7d0d. Read the comment docs.

Files with missing lines Coverage Δ
server/ai_http.go 10.00000% <100.00000%> (ø)
server/ai_worker.go 49.89059% <73.33333%> (+0.79557%) ⬆️

Copy link
Member

@rickstaa rickstaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ad-astra-video very clean pull request. Let's merge 🚀.

@rickstaa rickstaa merged commit 836d006 into livepeer:ai-video Nov 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Issues and PR related to the AI-video branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants