-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libcxxabi] Add a missing include for abort() #126865
Conversation
@llvm/pr-subscribers-libcxxabi Author: Takuto Ikuta (atetubou) ChangesThis is to fix a build error when we use Clang modules in Chromium. Full diff: https://github.com/llvm/llvm-project/pull/126865.diff 1 Files Affected:
diff --git a/libcxxabi/src/cxa_default_handlers.cpp b/libcxxabi/src/cxa_default_handlers.cpp
index b029982ea87c3..c48563bd44706 100644
--- a/libcxxabi/src/cxa_default_handlers.cpp
+++ b/libcxxabi/src/cxa_default_handlers.cpp
@@ -9,6 +9,7 @@
// new_handler.
//===----------------------------------------------------------------------===//
+#include <cstdlib>
#include <exception>
#include <new>
#include "abort_message.h"
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I used std::abort
instead because <cstdlib>
is not technically required to provide ::abort
.
This is to fix a build error when we use Clang modules in Chromium.
This is to fix a build error when we use Clang modules in Chromium.
This is to fix a build error when we use Clang modules in Chromium.
This is to fix a build error when we use Clang modules in Chromium.
This is to fix a build error when we use Clang modules in Chromium.
This is to fix a build error when we use Clang modules in Chromium.