adds default content for 403 and 404 pages

[markconroy]

Closes #698

What does this change?

1. Adds a variable in page-status.html.twig for "default_status_content"
2. We use this variable in the page--403/page--404.html.twig file to set a nice default message for these pages
3. When then check to see if a custom 403/404 page has been set (as a node) and if so, we set the new variable to false and use the content from the node

How to test

• Check by default we now have better 403/404 content.
• Then set custom nodes as the default for 403/404
• Check that the template content is overridden

[willguv]

Hi @markconroy thanks for this - was on my long list. How does a content designer set 403 and 404 pages please, and can I see our default?

[markconroy]

How does a content designer set 403 and 404 pages please

Within the CMS, you can create a node and then set that node as your 403 or 404 page. You can see in this screenshot, I have chosen /node/1 as my 404 page and left 403 page blank. This means the 403 page will use our hardcoded template and the 404 page will use whatever content is in Node 1.

Here's our (new) defaults when using the updated templates.

[willguv]

Thanks Mark, where's the error page setting please?

Is it possible to make a couple of minor changes to the default text?

On the 404, remove the last sentence "The requested page could not be found."

On the 403, again remove the last sentence " You are not authorized to access this page."

In both cases the wording above is friendlier and better

[markconroy]

Page setting is at: /admin/config/system/site-information

I'll get the default items removed.

[finnlewis]

@markconroy I've made a small change to address the php static analysis checks: 5afeb30

I tested before and after and the functionality works as outlined for me.

Could you just confirm that change looks good to you?

Cheers,

Finn

[finnlewis]

Works as detailed and tests are passing now :)

Thanks @markconroy