failing spec under logstash 2.x

[jsvd]

projects/logstash (git)-[2.2] % bin/rspec ./vendor/bundle/jruby/1.9/gems/logstash-input-file-2.0.3/spec/inputs/file_spec.rb:235 
Using Accessor#strict_set for specs
Run options:
  include {:locations=>{"./vendor/bundle/jruby/1.9/gems/logstash-input-file-2.0.3/spec/inputs/file_spec.rb"=>[235]}}
  exclude {:redis=>true, :socket=>true, :performance=>true, :couchdb=>true, :elasticsearch=>true, :elasticsearch_secure=>true, :export_cypher=>true, :integration=>true, :windows=>true}
F

Failures:

  1) LogStash::Inputs::File when wildcard path and a multiline codec is specified collects separate multiple line events from each file
     Failure/Error: expect(events.size).to eq(event_count)

       expected: 2
            got: 0

       (compared using ==)
     # ./vendor/bundle/jruby/1.9/gems/logstash-input-file-2.0.3/spec/inputs/file_spec.rb:242:in `(root)'
     # ./vendor/bundle/jruby/1.9/gems/rspec-wait-0.0.8/lib/rspec/wait.rb:46:in `(root)'
     # ./lib/bootstrap/rspec.rb:11:in `(root)'

Finished in 1.25 seconds (files took 0.993 seconds to load)
1 example, 1 failure

Failed examples:

rspec ./vendor/bundle/jruby/1.9/gems/logstash-input-file-2.0.3/spec/inputs/file_spec.rb:235 # LogStash::Inputs::File when wildcard path and a multiline codec is specified collects separate multiple line events from each file

Randomized with seed 23564

[guyboertje]

There are various sleeps throughout the code which make the rspec thread wait until the runner thread has had a chance to do its thing. The amount of time it waits for is OK on my MPB with SSD but I suspect that a loaded CI server might need longer sleeps.

I am fixing that now. The fix may need back porting.

[ph]

@guyboertje can we rewrite the case with rspec-wait this will try multiple times before failing?

[guyboertje]

@ph - I tried with rspec-wait but it did not work. Trying something of my own creation.

Unfortunately there is one situation where we expect nothing to happen and we can't put in a wait for that 😄

[ph]

we also have try {} in devutils, which is a bit different from rspec-wait. It might work in your case.

[jsvd]

what is strange is that using logstash master I don't get the same error. could be a result of poor case analysis on my part though.

[guyboertje]

@jsvd @ph - yes, I asked myself the same, why master is OK and branch is not.

[suyograo]

btw, this is failing on master too. http://build-eu-00.elasticsearch.org/view/LS%20Master/job/Logstash_Master_Default_Plugins/907/console